Issue: MASSIVE issues with TEMPLATES in v2.5.3!

Issue Tools
- View Changes

September 10, 2009 1:39 PM

Jaxel

Junior Member

MASSIVE issues with TEMPLATES in v2.5.3!

I build my tables in templates...

Template:framesSTR

Code:

[table] style="text-align: center" border="0" cellpadding="4" cellspacing="1" width="100%" class="tborder"
|-
! [b]Attack Name[/b]
! [b]Command[/b]
! [b]Level[/b]
! [b]IMP[/b]
! [b]DMG[/b]
! [b]GRD[/b]
! [b]HIT[/b]
! [b]CH[/b]
! [b]SC[/b]
! [b]NOTES[/b][/table]

at the end of a template.

Issue Details

Issue Number 831

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 2.5.3

Fixed Version 2.5.4

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

September 10, 2009 4:20 PM

pegasus

VaultWiki Team

The nesting problems you reported for tables were fixed in 2.5.3. So all the extra line breaks you added to your templates as a workaround in 2.5.2 are just that, line breaks.

Also, If you have indented each row in the template like above, this could disrupt the whitespace trimmer.

Reply

September 10, 2009 4:25 PM

Jaxel

Junior Member

Pegasus... I already removed the extra line breaks when I was trying to fix this problem.
http://www.8wayrun.com/wiki/How_Do_I_Code_My_Inputs

I feel like I'm being ignored here... like I'm getting the typical "its the user's fault" response...
I'm not an idiot, I'm a programmer myself, and I can tell this is a program problem.

Using this code... the problem still persists:

Code:

[template]4columnSTR| ICON | CODE | WIKI | DESCRIPTION | DIRECTIONALS (HOLD) 8-WAY RUN | 100%[/template]
[template]4columnROW
| [table] cellpadding="5" cellspacing="0" border="0" width="100%"
|-
| :7h:
| :8h:
| :9h:
|-
| :4h:
| :+:
| :6h:
|-
| :1h:
| :2h:
| :3h:
[/table]
| [table] cellpadding="5" cellspacing="0" border="0" width="100%"
|-
| [size=1][7][/size]
| [size=1][8][/size]
| [size=1][9][/size]
|-
| [size=1][4][/size]
| [size=1]+[/size]
| [size=1][6][/size]
|-
| [size=1][1][/size]
| [size=1][2][/size]
| [size=1][3][/size]
[/table]
| [table] cellpadding="5" cellspacing="0" border="0" width="100%"
|-
| [size=1]:[u]7h[/u]:[/size]
| [size=1]:[u]8h[/u]:[/size]
| [size=1]:[u]9h[/u]:[/size]
|-
| [size=1]:[u]4h[/u]:[/size]
| [size=1]:[u]+[/u]:[/size]
| [size=1]:[u]6h[/u]:[/size]
|-
| [size=1]:[u]1h[/u]:[/size]
| [size=1]:[u]2h[/u]:[/size]
| [size=1]:[u]3h[/u]:[/size]
[/table]
| [table] cellpadding="5" cellspacing="0" border="0" width="100%"
|-
| [size=1]up/back[/size]
| [size=1]up[/size]
| [size=1]up/forward[/size]
|-
| [size=1]back[/size]
| [size=1]plus[/size]
| [size=1]forward[/size]
|-
| [size=1]down/back[/size]
| [size=1]down[/size]
| [size=1]down/forward[/size]
[/table]
[/template]
[template]4columnEND| ICON | CODE | WIKI | DESCRIPTION[/template]

Once again, as seen as seen on the bottom of this page:
http://www.8wayrun.com/wiki/How_Do_I_Code_My_Inputs

Do you also notice that the link above is not being parsed? Obviously something is fucked up.

My major concern with my Wiki was the issues with Parser Functions... the wiki itself was working well, and the bugs and errors I was learning how to work around. This new update has created issues that I CAN'T work around, and it also failed to fix any of my Parser Functions problems.

September 10, 2009 4:33 PM

Jaxel

Junior Member

You want an exact example?

I have the following code:

Code:

[template]charBIG
| name		=The Hero King Algol
| image		=algSC4art1.jpg
| caption	=Algol as he appears in Soulcalibur IV
| firstgame	=Soulcalibur IV
| voiceactor	=?
| japanactor	=George Nakata (current)
| age		=Frozen in time
| birthplace	=An ancient dynasty whose name has been lost to history
| birthdate	=Meaningless now
| bloodtype	=Only pure power courses through him
| height	=Whatever he wills it to be
| weight	=Whatever he wills it to be
| family	=All in the past
| weapontype	=Assimilated Soul Calibur & Soul Edge
| weaponname	=Soul Calibur & Soul Edge
| fightstyle	=Command of the Flow of Power
[/template]

Calls up this template...

Code:

[table] align="right" border="0" cellpadding="0" cellspacing="0" style="padding-left:10px"
|-
| [table] border="0" cellpadding="6" cellspacing="1" class="tborder" width="300"
|-
| class="tcat" align="center" colspan="2" | {{{name}}}
|-
| class="alt1" align="center" colspan="2" | [image]{{{image}}}|300px|none|{{{caption}}}[/image]
|-
! align="center" colspan="2" | Character
|-
| class="alt1 smallfont" align="right" | [b]Debut[/b]
| class="alt1 smallfont" align="left"  | {{{firstgame}}}
|-
| class="alt2 smallfont" align="right" | [b]Voice (E)[/b]
| class="alt2 smallfont" align="left" | {{{voiceactor}}}
|-
| class="alt1 smallfont" align="right" | [b]Voice (J)[/b]
| class="alt1 smallfont" align="left" | {{{japanactor}}}
|-
! align="center" colspan="2" | Biography
|-
| class="alt1 smallfont" align="right" | [b]Age[/b]
| class="alt1 smallfont" | {{{age}}}
|-
| class="alt2 smallfont" align="right" | [b]Birthplace[/b]
| class="alt2 smallfont" align="left"  | {{{birthplace}}}
|-
| class="alt1 smallfont" align="right" | [b]Birthdate[/b]
| class="alt1 smallfont" align="left"  | {{{birthdate}}}
|-
| class="alt2 smallfont" align="right" | [b]Bloodtype[/b]
| class="alt2 smallfont" align="left"  | {{{bloodtype}}}
|-
| class="alt1 smallfont" align="right" | [b]Height[/b]
| class="alt1 smallfont" align="left"  | {{{height}}}
|-
| class="alt2 smallfont" align="right" | [b]Weight[/b]
| class="alt2 smallfont" align="left"  | {{{weight}}}
|-
| class="alt1 smallfont" align="right" | [b]Family[/b]
| class="alt1 smallfont" align="left"  | {{{family}}}
|-
! align="center" colspan="2" | Fighting Style
|-
| class="alt1 smallfont" align="right" | [b]Type[/b]
| class="alt1 smallfont" align="left"  | {{{weapontype}}}
|-
| class="alt2 smallfont" align="right" | [b]Weapon[/b]
| class="alt2 smallfont" align="left"  | {{{weaponname}}}
|-
| class="alt1 smallfont" align="right" | [b]Discipline[/b]
| class="alt1 smallfont" align="left"  | {{{fightstyle}}}
[/table]
[/table]

Viewing the source of the result:

Code:

<table align="right" border="0" cellpadding="0" cellspacing="0" style="padding-left: 10px; padding-left: 10px&amp;quot; padding-left: 10px&amp;quot; padding-left: 10px&amp;quot"><tr><td><table border="0" cellpadding="6" cellspacing="1" width="300" class="tborder"><tr><td align="center" colspan="2" class="tcat">The Hero King Algol</td></tr><tr><td align="center" colspan="2" class="alt1"><div class="thumb tleft"><a href="http://www.8wayrun.com/wiki/Image:algSC4art1.jpg" class="internal" title="Algol as he appears in Soulcalibur IV"><img border="0" src="attachment.php?postid=4838&amp;stc=1&amp;fromvw=1" width="300px" alt="Algol as he appears in Soulcalibur IV" /></a></div></td></tr><tr><th align="center" colspan="2" class="thead">Character</th></tr><tr><td align="right" class="alt1 smallfont"><b>Debut</b></td><td align="left" class="alt1 smallfont">Soulcalibur IV</td></tr><tr><td align="right" class="alt2 smallfont"><b>Voice (E)</b></td><td align="left" class="alt2 smallfont">?</td></tr><tr><td align="right" class="alt1 smallfont"><b>Voice (J)</b></td><td align="left" class="alt1 smallfont">George Nakata (current)</td></tr><tr><th align="center" colspan="2" class="thead">Biography</th></tr><tr><td align="right" class="alt1 smallfont"><b>Age</b></td><td class="alt1 smallfont">Frozen in time</td></tr><tr><td align="right" class="alt2 smallfont"><b>Birthplace</b></td><td align="left" class="alt2 smallfont">An ancient dynasty whose name has been lost to history</td></tr><tr><td align="right" class="alt1 smallfont"><b>Birthdate</b></td><td align="left" class="alt1 smallfont">Meaningless now</td></tr><tr><td align="right" class="alt2 smallfont"><b>Bloodtype</b></td><td align="left" class="alt2 smallfont">Only pure power courses through him</td></tr><tr><td align="right" class="alt1 smallfont"><b>Height</b></td><td align="left" class="alt1 smallfont">Whatever he wills it to be</td></tr><tr><td align="right" class="alt2 smallfont"><b>Weight</b></td><td align="left" class="alt2 smallfont">Whatever he wills it to be</td></tr><tr><td align="right" class="alt1 smallfont"><b>Family</b></td><td align="left" class="alt1 smallfont">All in the past</td></tr><tr><th align="center" colspan="2" class="thead">Fighting Style</th></tr><tr><td align="right" class="alt1 smallfont"><b>Type</b></td><td align="left" class="alt1 smallfont">Assimilated Soul Calibur &amp; Soul Edge</td></tr><tr><td align="right" class="alt2 smallfont"><b>Weapon</b></td><td align="left" class="alt2 smallfont">Soul Calibur &amp; Soul Edge</td></tr><tr><td align="right" class="alt1 smallfont"><b>Discipline</b></td><td align="left" class="alt1 smallfont">Command of the Flow of Power</td></tr></table></td></tr></table><br />

Notice the at the end? That shouldn't be there!

September 10, 2009 4:52 PM

Jaxel

Junior Member

This issue may sound like its not important, but it is...

EVERY SINGLE PAGE on my wiki starts with a template stub. Because of these extra line breaks being added after every table template, that means EVERY SINGLE PAGE on my wiki has immediate line breaks before the content of the page... and there is NOTHING I can do to fix it.

Example: http://www.8wayrun.com/wiki/Algol

Frankly, it seems like this new update is adding extra line breaks in a lot of places...

With all my pages, they work as follows:
{template callup for charBIG}
Immediate start of content...

Now they are showing up as follows:
{template callup for charBIG }
 Immediate start of content...

Reply
September 10, 2009 11:09 PM

pegasus

VaultWiki Team

I didn't mean to suggest that this is a "user's fault" problem. Line breaks (and whitespace, in general) are a very controversial issue that we are constantly discussing here, because there's not an easy way (at least not with vBulletin's handling of them) to distinguish intentional line breaks (ones that should be output) from ones that are added for readability - making this an ongoing problem. My previous post was merely attempting to explain that this distinction had changed slightly and that you may need to modify some templates.

The end of table space was the only change to line break handling in 2.5.3.

I am currently working on this... so hold on...

Since you are also getting line breaks after templates keep this in mind: templates are treated as inline elements. Any line breaks after a template call will remain there. If your template creates a floated box, don't add a line break between the template's closing tag and the text.

Reply
September 11, 2009 12:25 AM

pegasus

VaultWiki Team

As it has had to be for every other BB-Code in vBulletin's parser (since \n is treated as and is usually treated as &lt;br&gt;), the extra line break in nested tables will have to be acceptable (the 2.5.2 behavior). 2.5.4 will revert to the previous behavior. You can do this yourself by using the 2.5.2 versions of special_class_bbcode.php AND special_plugins_bbcode.php.

In this case, you will not need to modify your templates as I suggested above...

In the future we (the VaultWiki developers) will have to be more communicative on the whitespace issue and the differences in handling between vBulletin versus other editors (such as MediaWiki), so as to avoid such confusion and the unnecessary waste of our customers' time by reverting changes one build later.

Sorry for all this confusion today.

As for your ongoing Parser Extensions woes, I believe the live version of the ZIP now contains the fix for IF (it's just a file patch).

Keep in mind that even with the revert to the end of table break, the whitespace after a template is still preserved, so you should not be adding line breaks after the closing tag.

Reply
September 11, 2009 6:19 AM

Jaxel

Junior Member

Thanks... I uploaded the 2.5.2 version of special_class_bbcode.php and special_plugins_bbcode.php. But it once again broke the "|-" parsing, as well as as adding the TEXT "[/noedit][noedit]" at the end of every template. I reuploaded 2.5.3.. and now everything seems to be working fine... what the hell?

Also, the Parser Extensions are only SLIGHTLY fixed... In the new bug report I submitted, it outlined TWO problems with the plugin. You marked it as a duplicate because ONE of the problems is the old one. I have outlined the new issues in the new bug report...

http://www.crackedeggstudios.com/issues/827/

Reply
September 11, 2009 6:40 AM
Jaxel

Junior Member
Let me show you an example of one of the persistant problem. Its shown in the attached image.

Code:

[template]charSML| chr=Algol | img=sc4alg[/template] [template]4columnSTR| ATTACK | COMMAND | PUNISH | NOTES | Seong Mi-na: Punishing Algol[/template] [template]4columnROW| Alnilam Wezen | :6::A::A::B: | :4::B:[/template] [template]4columnROW| Fil Qadam | :2::K: | FC :2::A: | Same for FC 2K[/template] [template]4columnROW| Metallah Mufrid | :6::6::B::A: | :3::B:[/template] [template]4columnEND| ATTACK | COMMAND | PUNISH | NOTES[/template]

In the old code, the two tables would have been lined up evenly, even with the code above. Now in order to get the tables to line up, I would have to code it as follows:

Code:

[template]charSML| chr=Algol | img=sc4alg[/template][template]4columnSTR| ATTACK | COMMAND | PUNISH | NOTES | Seong Mi-na: Punishing Algol[/template] [template]4columnROW| Alnilam Wezen | :6::A::A::B: | :4::B:[/template] [template]4columnROW| Fil Qadam | :2::K: | FC :2::A: | Same for FC 2K[/template] [template]4columnROW| Metallah Mufrid | :6::6::B::A: | :3::B:[/template] [template]4columnEND| ATTACK | COMMAND | PUNISH | NOTES[/template]

This is problematic because it makes the code harder to understand and makes the wiki harder to program. Would it be possible to get the template callup to ignore the immediate line break? It did it in 2.5.2, I see no reason why it couldn't remain that way. If I wanted an extra line break, I would put the extra line break in myself. The less that happens automatically, the better; manual gives you more control.

Except for the parser functions, I pretty much prefer things the way they were done in 2.5.2... thankfully I was able to reupload all the 2.5.2 files from my server and the wiki still works.
Reply
September 11, 2009 10:21 AM
Jaxel

Junior Member
Well I've narrowed down the error to this line of code in special_class_template.php

Code:

function clean_value($text) { // un-quote quoted tag options return preg_replace('#=((?:"|\'|"))(.*)\1\]#sU', '=\2]', $text); }

When this function is changed to return $text; everything works fine for me... of course the quoted tag bug is back. So adding the fix for this previous bug created this new bug. I never had issues with this previous bug, so I've changed the code to this to:

Code:

function clean_value($text) { // un-quote quoted tag options return $text; }

As you can see, I would rather have this old bug, than the new bug. The nesting tables bug is ALSO back; but as I said in the previous thread, I discovered a simple workaround for it... so that is no longer a concern.
Reply
September 11, 2009 12:50 PM

pegasus

VaultWiki Team

Can you post the code for your template charSML so we can try to get everything working together like in 2.5.2, except with the quoted tags fix, for the next build.

Reply

September 11, 2009 1:49 PM

Jaxel

Junior Member

I dont see why you would need the template for charSML... it happens in EVERY template...

Code:

[table] align="right" border="0" cellpadding="0" cellspacing="0" style="padding-left:10px"
|-
| [table] style="text-align: center" border="0" cellpadding="6" cellspacing="1" class="tborder"
|-
| class="alt2" | [article={{{chr}}}]http://www.8wayrun.com/images/avatars/{{{img}}}.jpg[/article]
|-
! class="thead" | [article]{{{chr}}}[/article]
[/table]

[/table]

September 11, 2009 3:11 PM
pegasus

VaultWiki Team
Okay, all of this should be satisfied for the next build:

Line break is not added after TABLE close (from 2.5.2). This will preserve the behavior you like.
strip_space_after is used for TABLE close (from 2.5.2). This will remove that unwanted line break between templates, but that is used for readability.
NOEDIT is ignored when fixing BB-Code nesting (to allow STR, ROW, END templates). This will allow the template section edit fix AND won't close TABLEs opened in templates.
strip_space_after is passed to NOEDIT. This means that if a closing TABLE is the last item in the template (no whitespace or text after), its strip_space_after parameter will be copied to the wrapping NOEDIT, so the space is still stripped (see #2).

You can see all these elements working correctly in Demo:Alex Kidd.
Reply

+ Reply

All times are GMT -4. The time now is 3:32 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: MASSIVE issues with TEMPLATES in v2.5.3!

Issue Tools