Issue: MASSIVE issues with TEMPLATES in v2.5.3!

Issue Tools
- View Changes

September 10, 2009 1:39 PM

Jaxel

Junior Member

MASSIVE issues with TEMPLATES in v2.5.3!

I build my tables in templates...

Template:framesSTR

Code:

[table] style="text-align: center" border="0" cellpadding="4" cellspacing="1" width="100%" class="tborder"
|-
! [b]Attack Name[/b]
! [b]Command[/b]
! [b]Level[/b]
! [b]IMP[/b]
! [b]DMG[/b]
! [b]GRD[/b]
! [b]HIT[/b]
! [b]CH[/b]
! [b]SC[/b]
! [b]NOTES[/b][/table]

at the end of a template.

Issue Details

Issue Number 831

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 2.5.3

Fixed Version 2.5.4

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

September 10, 2009 1:47 PM

pegasus

VaultWiki Team

VaultWiki doesn't bother closing tags that were opened in a template - this is actually something the browser is doing because it's counting the comment tags as nested HTML rather than what they are - comments. Please post all the code that makes up this page so we can reproduce this behavior.

Reply

September 10, 2009 1:50 PM

Jaxel

Junior Member

Template:4columnSTR: http://www.8wayrun.com/wiki/Template:4columnSTR
Template:4columnROW: http://www.8wayrun.com/wiki/Template:4columnROW
Template:4columnEND: http://www.8wayrun.com/wiki/Template:4columnEND

Called up using this...

Code:

[template]4columnSTR| ATTACK | COMMAND | PUNISH | NOTES | Seong Mi-na: Punishing Algol[/template]
[template]4columnROW| Alnilam Wezen | :6::A::A::B: | :4::B:[/template]
[template]4columnROW| Fil Qadam | :2::K: | FC :2::A: | Same for FC 2K[/template]
[template]4columnROW| Metallah Mufrid | :6::6::B::A: | :3::B:[/template]
[template]4columnEND| ATTACK | COMMAND | PUNISH | NOTES[/template]

September 10, 2009 1:55 PM

Jaxel

Junior Member

VaultWiki is absolutely doing it... the close table tag in the code of the first post of this thread, I did not add that... the forum added it by itself.

Reply
September 10, 2009 1:56 PM

pegasus

VaultWiki Team

Before reviewing your templates, I have made a small change to the code involved here. Try downloading the ZIP again and replacing your vault/special_class_bbcode.php with the one in the ZIP.

Originally Posted by Jaxel

VaultWiki is absolutely doing it... the close table tag in the code of the first post of this thread, I did not add that... the forum added it by itself.

What happened in the first post is something VBULLETIN does, not VaultWiki. However, templates are handled differently than forum posts - the BB-Code isn't parsed until all the templates are put together.

Reply
September 10, 2009 2:02 PM

Jaxel

Junior Member

I replaced special_class_bbcode and it didn't fix anything...

Why would this stuff work before and suddenly break now?

Reply
September 10, 2009 2:09 PM

pegasus

VaultWiki Team

Thanks for the additional information (regarding the first post). This is due to code in vBulletin that tries to "fix" unterminated BB-Code tags.

This is now happening because the NOEDIT BB-Code is now inserted around each template to prevent the blank edit boxes from appearing - however, the wrapped code triggers the "fix".

I have implemented a workaround for NOEDIT. If you would download and replace that file again (sorry), I believe the issue will cease (you may need to clear the article post cache - CES VaultWiki > Wiki Article Tools > Clean Article Post Cache).

Reply
September 10, 2009 2:12 PM

Jaxel

Junior Member

Okay, this looks PARTIALLY fixed... its closing the tables now... but its not reading the row start in the ROW templates either... http://www.8wayrun.com/wiki/How_Do_You_Create_Tables

You can see "|-" in some cells...

And what do you mean by "workaround"... I prefer fixes, not workarounds...

Reply
September 10, 2009 2:28 PM

Jaxel

Junior Member

Some of my pages are a mile long now... hah...
http://www.8wayrun.com/wiki/Seong_Mi...V_-_Frame_Data

The templates worked fine in the old system... why the change? What is this NOEDIT bbcode? What was wrong with the built in NOPARSE bbcode?

It also looks like the problems I have been clamoring about with Parser Extensions haven't been fixed.

Reply
September 10, 2009 2:47 PM

pegasus

VaultWiki Team

NOEDIT is the fix for: http://www.crackedeggstudios.com/issues/813/
which you reported. NOPARSE isn't capable of doing this.

These changes count as a "workaround" and not a "fix" because a "fix" would require us to remove a core feature of vBulletin. Instead we are adding some code that enables everything to play nice together.

I have been able to reproduce the problem using the templates you posted and the issue has been fixed. You need to replace vault/special_plugins_bbcode.php.

Reply
September 10, 2009 2:51 PM

Jaxel

Junior Member

This problem HASN'T been fixed... as you can clearly see here:
http://www.8wayrun.com/wiki/Setsuka_...V_-_Frame_Data

Its not reading the start of a ROW "|-" at the beginning of a template.

BTW, that edit bug had nothing to do with the H tag on my forums, it had to do with the failure of nesting tables, which I have since fixed on my forums (I discussed the fix in a previous thread)

Reply
September 10, 2009 3:18 PM

Jaxel

Junior Member

Forget it... this is taking too long... I'll just rewrite all my templates to put |- at the end of previous templates, instead of at the beginning.

*EDIT* Nevermind... this didn't work... It appears that in a template, its just not parsing the first line AT ALL. So if I move the |- to the bottom, that means the first row is one of the cells... and it instead doesn't parse the cell start.

I honestly can't tell whats purpose of this "upgrade". It didn't fix any of the issues I had, only made them worse...

How do I downgrade to a previous version?

Reply
September 10, 2009 3:32 PM

pegasus

VaultWiki Team

I honestly don't see how it made ALL of your issues worse. All I see is that it introduced this issue, and as I mentioned, this was fixed.

Perhaps you updated the wrong file by mistake. Replace all of them to be sure.

Reply
September 10, 2009 3:41 PM

Jaxel

Junior Member

Okay... now its working... but it appears you guys changed the table codes...

For some reason, a <br /> is being added at the end of EVERY one of my tables... Why? This is happening ONLY in tables being ended through templates. If the table is written out normally, it doesn't add it. But when my tables are through templates, it adds the BR, and I need to not have that.

Reply
September 10, 2009 3:46 PM

Jaxel

Junior Member

Here is example: http://www.8wayrun.com/wiki/How_Do_I_Code_My_Inputs

Reply

September 10, 2009 3:58 PM

Jaxel

Junior Member

Actually... it seems worse than that... here is some code...

Code:

[template]4columnSTR| ICON | CODE | WIKI | DESCRIPTION | DIRECTIONALS (HOLD) 8-WAY RUN | 100%[/template]
[template]4columnROW
	|	[table] cellpadding="5" cellspacing="0" border="0" width="100%"
		|-
		| :7h:
		| :8h:
		| :9h:
		|-
		| :4h:
		| :+:
		| :6h:
		|-
		| :1h:
		| :2h:
		| :3h:
		[/table]
	|	[table] cellpadding="5" cellspacing="0" border="0" width="100%"
		|-
		| [size=1][7][/size]
		| [size=1][8][/size]
		| [size=1][9][/size]
		|-
		| [size=1][4][/size]
		| [size=1]+[/size]
		| [size=1][6][/size]
		|-
		| [size=1][1][/size]
		| [size=1][2][/size]
		| [size=1][3][/size]
		[/table]
	|	[table] cellpadding="5" cellspacing="0" border="0" width="100%"
		|-
		| [size=1]:[u]7h[/u]:[/size]
		| [size=1]:[u]8h[/u]:[/size]
		| [size=1]:[u]9h[/u]:[/size]
		|-
		| [size=1]:[u]4h[/u]:[/size]
		| [size=1]:[u]+[/u]:[/size]
		| [size=1]:[u]6h[/u]:[/size]
		|-
		| [size=1]:[u]1h[/u]:[/size]
		| [size=1]:[u]2h[/u]:[/size]
		| [size=1]:[u]3h[/u]:[/size]
		[/table]
	|	[table] cellpadding="5" cellspacing="0" border="0" width="100%"
		|-
		| [size=1]up/back[/size]
		| [size=1]up[/size]
		| [size=1]up/forward[/size]
		|-
		| [size=1]back[/size]
		| [size=1]plus[/size]
		| [size=1]forward[/size]
		|-
		| [size=1]down/back[/size]
		| [size=1]down[/size]
		| [size=1]down/forward[/size]
		[/table]
[/template]
[template]4columnEND| ICON | CODE | WIKI | DESCRIPTION[/template]

Example: http://www.8wayrun.com/wiki/How_Do_I_Code_My_Inputs (scroll to the way bottom)
Notice the extra line break inside the table cells.

If I use normal table tags, isntead of 4columnSTR and 4columnEND, it works fine. But its having problems through templates.

+ Reply

All times are GMT -4. The time now is 9:22 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: MASSIVE issues with TEMPLATES in v2.5.3!

Issue Tools