Issue: [4.1 Beta 3] VW BB codes show on XF help page due to missing custom_bb_code_example.<bb_code_id> phrases

Issue Tools
- View Changes

September 12, 2019 12:37 PM

ACL

Regular Member

[4.1 Beta 3] VW BB codes show on XF help page due to missing custom_bb_code_example.<bb_code_id> phrases

A number of VaultWiki bbcodes appear in the XenForo help page for bbcodes despite there being no example usage defined. XenForo explains this field as:

If you provide an example, this BB code will appear on the BB code help page.

This help page loops through the bbcodes with the condition $bbCode.example is not empty. According to the BbCode entity structure, this is a getter that returns a phrase with the name custom_bb_code_example.<bb_code_id>.

These phrases don't appear exist in the add-on's phrases.xml data. Opening and resaving a VaultWiki bbcode will create an empty phrase "custom_bb_code_example.<bb_code_id>" which removes it from the BBcode help page.

The VW.org XF demo currently demonstrates the reported issue: https://www.vaultwiki.org/xf/index.p...odes/#autolink

Perhaps these VW bb code phrases aren't being included due to the workaround described in issue 5810 where a different add-on id is used?

I wonder if changing these bb code related phrases to the main vw/vw add-on id might solve the issue?

Issue Details

Issue Number 5854

Issue Type Bug

Project VaultWiki 4.x Series

Category BB-Code Parsing

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.0 Beta 3

Fixed Version 4.1.0 Beta 4

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 14, 2019 12:00 PM

pegasus

VaultWiki Team

In the next build, fixed the XF help page not following the Wiki-Related setting "Show BB-Code in the site's FAQ?" (which for many of them will not work if set to Yes).

In the next release, fixed missing phrases for default BB-Codes that have the aforementioned setting set to Yes by default (such as the generic WIKI BB-Code).

Reply

+ Reply

All times are GMT -4. The time now is 1:19 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 3] VW BB codes show on XF help page due to missing custom_bb_code_example.<bb_code_id> phrases

Issue Tools