• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 4.x Series
    • Bug
    • [4.1 Alpha 3] Wiki Index: vwdiscussion block heading does not need block-filterBar wrapper, Feeds: vw-feed-empty lack of padding

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: [4.1 Alpha 3] Wiki Index: vwdiscussion block heading does not need block-filterBar wrapper, Feeds: vw-feed-empty lack of padding

    • Issue Tools
      • View Changes
    1. issueid=5684 March 27, 2019 10:00 AM
      ACL ACL is offline
      Regular Member
      [4.1 Alpha 3] Wiki Index: vwdiscussion block heading does not need block-filterBar wrapper, Feeds: vw-feed-empty lack of padding

      1) vwdiscussion block heading CSS tweaks

      Code:
      <div class="block-filterBar">
      	<h3 class="block-header" itemprop="name">Discussions for Wiki</h3>
      </div>
      Could simply be:
      Code:
      <h3 class="block-header" itemprop="name">Discussions for Wiki</h3>
      On the default XenForo style, it makes no difference to the end styling and it removes some unnecessary html. In a third-party style, the combination of the block-filterBar wrapper and nested block-header element leads to poor contrast of the heading text against the background, which the above change addresses.

      2) vw-feed-empty lack of padding
      <div class="vw-feed-entry vw-feed-empty"> lacks padding around the "There are no feeds in this part of the wiki" message. Adding the block-row class looks better.
    Issue Details
    Issue Number 5684
    Issue Type Bug
    Project VaultWiki 4.x Series
    Category Styling / CSS
    Status Fixed
    Priority 5 - Minor Bugs / Small Tweaks
    Affected Version 4.1.0 Alpha 3
    Fixed Version 4.1.0 Beta 1
    Milestone (none)
    Software DependencyXenForo 2.x
    License TypePaid
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. March 27, 2019 10:12 AM
      ACL ACL is offline
      Regular Member
      3) For /wiki-watch/, the same poor text contrast in 1) occurs for the filterBar header in a third-party style. In this case, maybe you could delete this heading, since it is already taken care of in the page title right above block-filterBar:
      Code:
      <h1 class="p-title-value">Watched Wiki Content</h1>
      4) "Post New Feed" (wiki/?do=create&itemtypeid=10) changes back to the main "Wiki" navigation tab.
      Reply Reply  
    2. March 27, 2019 11:16 AM
      pegasus pegasus is offline
      VaultWiki Team
      The following are tweaked in the next release:
      1) Unneeded block-filterBar removed.
      2) Added block-row in a way that is as consistent with public:vw_feed_view as possible in this context.

      But:
      3) No change here, as the block-filterBar is sometimes actually used here for filters. It should be noted that nearly all content-list headings are wrapped in block-filterBar if the heading might be used to stack filters. If this is an issue in your custom style, then you may want to add a custom CSS rule to that style to address the clash.
      4) If this were changed and you click "Post New Feed" from the wiki tab, then the tab would change in the other direction. Also, depending on the kind of feed you eventually create, the feed itself will open under either the Wiki tab or the Feeds tab. In general, the Feeds tab is used as a discovery list for feeds that actually exist under Wiki. It is only used as a wrapper for personal feeds which belong to a user and not the wiki.
      Reply Reply  
    3. March 27, 2019 11:30 AM
      ACL ACL is offline
      Regular Member
      For 3), to clarify I am suggesting to keep block-filterBar as-is, but then remove the nested header. This header says the same thing as the page title immediately above it.

      • Page title (p-title-value) says: Watched Wiki Content
      • Nested block-header says: Watched Wiki Content


      But thanks for the CSS suggestion - that is my back-up plan .

      4) Thanks for the explanation, yes now I think it is best to leave this one alone.
      Reply Reply  
    4. March 27, 2019 11:53 AM
      ACL ACL is offline
      Regular Member
      In vw_block.less, I added one line (bold) to fix the contrast issue with the custom style:
      .block-filterBar .block-header {
      background: transparent;
      color: @xf-blockFilterBar--color;
      border: none;
      flex-grow: 1;
      padding: 0;
      }

      This just ensures that the nested heading text color will use the block-filterBar text colour.
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 3:05 PM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2025 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2025 DragonByte Technologies Ltd.
    Copyright © 2008 - 2024 VaultWiki Team, Cracked Egg Studios, LLC.