Issue: Cannot delete a rating

Issue Tools
- View Changes

September 17, 2022 3:05 AM

mazzly

Junior Member

Cannot delete a rating

Trying to delete a rating I created, Modal opens, but when clicking "continue" nothing happens..

Dev tools shows:
core-compiled.js?_v=ed2cf4b9:63 Was not provided an object or HTML content

Issue Details

Issue Number 6324

Issue Type Bug

Project VaultWiki 4.x Series

Category Moderator Tools

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.5

Fixed Version 4.1.5

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 17, 2022 2:12 PM

pegasus

VaultWiki Team

Fixed in the next release. The fix will also be included in next month's patches, because a user should not be able to generate content that a moderator is unable to remove (what if they post SPAM or other disallowed content in their rating's comment).

In src/addons/vw/vw/_core/view/proxy/rate/vw.php, find:

Code:

$templater = vw_Hard_Core::fetch_template('vw_content_rating_delete');

BEFORE it, add:

Code:

vw_Hard_Core::model('URL')->get($rater->existing);

In src/addons/vw/vw/_core/controller/proxy/rate/vw.php, find:

Code:

		$dm = vw_Hard_Core::controller('DM')->create('Rating', 'SILENT');
		$dm->set_existing($this->existing);
		$dm->delete();
		unset($dm);

		return $this->controller->reply_redirect($this->context['url'], 'vw_rating_deleted');

Replace with (probably a scrollbar here):

Code:

		$dm = vw_Hard_Core::controller('DM')->create('Rate', 'SILENT');
		$dm->set_existing($this->existing);
		$dm->delete();
		unset($dm);

		vw_Hard_Core::model('URL')->get($this->context);

		$returnURL = $this->context['url_jd'];
		$type = vw_Hard_Core::model('Node')->one($this->context);

		if (!empty($type['isRoutable']) OR !empty($type['isItem']))
		{
			$returnURL .= 'do=ratings';
		}
		else
		{
			$returnURL .= 'action=ratings';
		}

		return $this->controller->reply_redirect($returnURL, 'vw_rating_deleted');

After these changes, I was able to successfully remove a rating I made on my wiki.

September 18, 2022 9:41 AM
mazzly

Junior Member
After applying patch I tried deleting, the modal didn't dispensary when clicking continue.. and same message still in console...

When refreshing the page I see

Code:

#!-- XEN:VWPHRASE vw_content_no_ratings ARGS() --#

But also the page still has the star rating that was given...

I also can't add any new rating to the page (it seems it still thinks I have given a rating..)
Reply
September 18, 2022 12:04 PM
pegasus

VaultWiki Team
Fixed the missing add-rating controls in the Rating tab when the page already has an average rating but the user hasn't submitted their own rating yet. In src/addons/vw/vw/_core/model/rating/vw.php, find:

Code:

if (!empty($item['ratingcount']))

BEFORE it, add:

Code:

if ($canrate === null) { $canrate = vw_Hard_Core::model('UI')->check('can_rate_tab', $item); } $item['canrate'] = $canrate;

Still wondering about the messed up average after deleting. I'll have to try some fresh tests as I didn't start with a clean average when I did this yesterday.
Reply

September 18, 2022 6:53 PM

pegasus

VaultWiki Team

Okay, this is fixed in the next release. I found a lot of other related issues that are also fixed:

Code:

Changed: faster calculation of average ratings [since: 4.1.0 RC 2] [lite: no]
Changed: ratings of minor edits affect the page rating less [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: edit ratings won't submit from history list view [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: missing history compare choices on reload after previous compare
Fixed Bug: missing phrase for empty ratings list [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: no differentiation between ratings list for edit vs whole page [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: duplicate parameters in edit warning URLs [since: 4.1.0 Alpha 1] [in: XF >= 2.0]
Fixed Bug: duplicate parameters in edit bookmark URLs [since: 4.1.0 Alpha 1] [in: XF >= 2.1]
Fixed Bug: deleting page rating redirects to current edit ratings [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: duplicate parameters in edit rating URLs [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: deleted ratings take an hour to affect averages [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: fatal error viewing ratings list for an edit [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: [note#34911] deleting ratings doesn't update rating count [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: [note#34911] rating tab has no option to add rating if page already has ratings [since: 4.1.0 RC 2] [lite: no]

There are probably more. I'm not done checking all the views yet, but the problems you had reported are taken care of.

September 19, 2022 8:30 AM

mazzly

Junior Member

After above fix patched, I'm able to add more ratings..

Deleting still doesn't actually delete it, and now the page shows an average score and "2 ratings", opening the "2 ratings" then shows there are no ratings..

Reply
September 19, 2022 9:39 AM

pegasus

VaultWiki Team

Deleting still doesn't actually delete it ... then shows there are no ratings

So the rating was actually deleted, the problem is the average and the count used to make the average didn't update as expected.

Yes, this is all in the changelog I posted above.

deleting ratings doesn't update rating count
...
deleted ratings take an hour to affect averages

I reduced the time from an hour in the next release. Sometimes it will be instant, but sometimes it might still take a minute.

Also, since I foresee it being a question in the future, I will leave it here -- the number of ratings next to the average will not always match the total number of ratings (usually the number shown would be lower than the total ratings). At the page level, the number next to the average is the number that was used to make the average, not all the ratings that were ever made for that page.

Reply

September 20, 2022 4:18 PM

pegasus

VaultWiki Team

Code:

Fixed Bug: no link to ratings list if ratingcount is 0 due to age [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: displayed rating count differs from number in ratings list [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: whole attachment ratings list doesn't include edit ratings [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: broken HTML in ratings list [in: vB] [lite: no]
Fixed Bug: parent ratings list gives no credit to actual rated content [in: vB] [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: parent ratings list has no links to actual rated content [in: XF] [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: feed rating has no link to ratings list [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: no differentiation between ratings list for feed entry vs whole feed [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: whole feed ratings list inaccessible [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: invalid nodetype error submitting rating for feed entry [since: 4.1.0 RC 2] [lite: no]
Fixed Bug: duplicate parameters in feed entry rating URLs [since: 4.1.0 RC 2] [lite: no]

... and that concludes my sweep of rating-related issues.

Now:
- New ratings save more reliably
- Average ratings are updated closer to expectations
- Missing ratings lists (such as feed entries) are now accessible
- Possible to access the ratings list for moderation purposes even if the average has become 0
- Clearer indication of total ratings vs ratings used to calculate averages
- Clearer indication whether you are viewing ratings for 1 edit vs all edits, etc

+ Reply

All times are GMT -4. The time now is 3:48 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Cannot delete a rating

Issue Tools