XF1.5, AMP pages broken since VaultWiki installed

[mazzly]

We have AMP versions of our threads with the following plugin https://xenforo.com/community/resour...-xenforo.5696/

Since the installation of VaultWiki a day ago, google search console now started complaining about broken AMP pages..

Looking at the amp variants now and running validation check, there are a bunch of custom VW_* <script> that try to load at the bottom of the page, which is not allowed with AMP pages. It has also broken some other small things with AMP content.

Example link: https://www.thetolkienforum.com/thre...r.19028/?amp=1

Problem is that I can't find where these scripts/tags are inserted/modified.

How/where can I modify so that those scripts/modifications are not done with ?amp=1 exists in the URL?

Would be nice if someone could provide help with which template I need to modify to prevent VW from inserting those tags..

[pegasus]

Do you know what the appropriate test is to check whether AMP-mode is active?

The script tags are not adding via a template. They are appended in PHP. We would have to add a PHP test to see if the add-on has activated AMP-mode for a request.

Checking for ?amp=1 alone is not sufficient. For example, I can just add it to the URL of this page, and nothing will happen because I don't have the AMP-addon installed. Or even if I do, maybe I have the add-on disabled or the add-on's settings disabled. But if I add the test for ?amp=1 to VaultWiki, then VaultWiki will incorrectly perform AMP-mode even though there is not AMP-mode right now.

[mazzly]

Sorry I do not know what the appropriate test to check if AMP-mode is activated..

I don't necessarily agree that ?amp=1 is not a sufficient test? could it maybe be a specifiable param to disable insertion of extra script tags?

Also: Why are there a bunch of script tags inserted to normal thread_view? shouldn't those be added only for wiki-related pages?

Could you tell me which .php file to modify if I want to add the ?amp=1 test myself?

[pegasus]

They are added to thread_view because a regular post can use wiki-related BB-Codes even though it is not a wiki-related page. Because post content is cached, the script tags cannot be queued directly when the BB-Code tags are parsed. Instead we have to assume that any BB-Code might be parsed, and pre-load a library. The library will load other scripts after the page loads, if it decides the extra scripts are needed.

You can write a listener to override vw_Global_View_XF2 ([vault/core, library/vw/_core, src/addons/vw/vw/_core]/view/global/xf2.php) using the event vw_load_view in vw_Hard_Core::resolve_class_name (vault/core/model/vw.php, vault/_hard/core.php, library/vw/_hard/core.php, src/addons/vw/vw/_hard/core.php).

You may want to affect one or more of the following methods:
- add_script
- get
- render_script_tag

[pegasus]

The appropriate test is to ensure all of the following:
- Check that the URL has ?amp=1
- Check that the add-on NixFifty_AMP is active.
- Check that the controllerResponse has: containerParams['AMP']; and/or templateName ending in _amp. This is only true for specific forum pages.

If all of these are true for a given request, then the response will be in AMP-mode. If one or more is false, then the response will not be AMP-mode.

This test will be performed in the next build of VaultWiki 4.1.x. If AMP-mode is active, wiki-related Javascript tags will not appear in the output.

[mazzly]

Hmm I can't find that file in XF root. (It is XF1.5)

is VaultWiki 4.1.x also available for XF1.5?

[pegasus]

For XF1.5 the file would be view/global/xf.php which extends view/global/vw.php

4.1.x is available for XF 1.2-1.5.