Issue running Forumrunner with Vault Wiki

**mickknutson** · March 31, 2011

http://www.forumrunner.net/forum/showthread.php?p=2710

Basically I am getting these issues viewing threads in my forum with forumrunner if vault wiki is NOT disabled:

I was able to find in the logs the errors:

Access logs:

Code:

174.252.76.27 - - [31/Mar/2011:14:16:04 -0700] "GET /forum/customavatars/avatar2743_1.gif HTTP/1.1" 200 3345 "-" "Dalvik/1.2.0 (Linux; U; Android 2.2.1; DROIDX Build/VZW)"
174.252.76.27 - - [31/Mar/2011:14:16:04 -0700] "GET /forum/customavatars/avatar2743_1.gif HTTP/1.1" 200 3345 "-" "Dalvik/1.2.0 (Linux; U; Android 2.2.1; DROIDX Build/VZW)"
174.252.76.27 - - [31/Mar/2011:14:16:11 -0700] "POST /forum/forumrunner/request.php HTTP/1.1" 500 - "-" "Forum Runner for Android"

error logs:

Code:

[Thu Mar 31 14:16:11 2011] [error] [client 174.252.76.27] PHP Fatal error:  Call to a member function fetch_instance() on a non-object in ~/public/forum/forumrunner/include/get_thread.php(810) : eval()'d code on line 5

Here is line 810:

Code:

($hook = vBulletinHook::fetch_hook('showthread_query')) ? eval($hook) : false;

Any ideas?

Is there anyway we can work on the integration so I can use both?

**pegasus** · March 31, 2011

Yeah, make sure forum runner calls the init_startup hook otherwise the classes aren't going to be loaded and you'll get fatal errors.

**pegasus** · March 31, 2011

Okay, I reviewed the ForumRunner code, and it DOES call init_startup, but it wraps showthread_query inside a function. showthread_query is not inside a function in stock vBulletin and thus all variables and objects in the global scope are available to it.

This is not the case with the ForumRunner code design. If they are going to take normally global hooks out of global context, then they need to create local references to every $GLOBALS key before calling the hook. I suspect this issue probably exists wherever they re-used default hooks.

However, it's probably best if they either took out the hooks or made their own. Postbit factory plugins had to be agnostic already anyway, so there shouldn't be fatal errors with them caused by removals.

**mickknutson** · March 31, 2011

Originally Posted by pegasus

Yeah, make sure forum runner calls the init_startup hook otherwise the classes aren't going to be loaded and you'll get fatal errors.

So if I added this before line 810 it might work:

Code:

($hook = vBulletinHook::fetch_hook('init_startup')) ? eval($hook) : false;

**pegasus** · March 31, 2011

This is not a good idea. As per my previous post, it would be better to add this before line 810:

Code:

global $vault;

**mickknutson** · March 31, 2011

Sorry I was impatient, but I did what I asked above

Code:

($hook = vBulletinHook::fetch_hook('init_startup')) ? eval($hook) : false;

and it worked!

**pegasus** · March 31, 2011

Okay, but you should probably forward my explanation of the cause to the Forum Runner people: http://www.vaultwiki.org/threads/5037/#post13089

**ClemsonJeeper** · March 31, 2011

Greetings, Rob from Forum Runner here.

Your analysis is correct. We use functions so any globals added by hooks will need to be added to our code.

I'll go ahead and add the global $vault to the add-on. Are there any other places where this would make a difference?

**pegasus** · March 31, 2011

It appears for now that this is the only location. I expect that this will no longer be an issue when we release our new version, since we fully move to PHP 5 and call our functions statically.