Correct method in upgrading VB3.8 to VB4.0?

[Jaxel]

New issue... having problems with nested tables... using the same exact code...

OLD: http://beta.8wayrun.com/wiki/How_Do_I_Code_My_Inputs
NEW: http://www.8wayrun.com/wiki/How_Do_I_Code_My_Inputs

[pegasus]

It seems the difference is that in the NEW wiki, you've enabled the Book TOC to be included on all chapter pages, and there isn't enough vertical white-space for it to find a good spot to place the TOC.

Either turn off the Book TOC (Settings > Options > VaultWiki: Article Display Options > Show Book Table of Contents in Chapters?) or add a line break before your tables start.

As for the broken IFs, this is a known issue: http://www.vaultwiki.org/issues/1911/

[Jaxel]

Alright, thanks pegasus, that bug fix, fixed the IF parsing problem.

However, the Book TOC was only part of the other problem...

OLD: http://beta.8wayrun.com/wiki/How_Do_I_Code_My_Inputs
NEW: http://www.8wayrun.com/wiki/How_Do_I_Code_My_Inputs

Scroll down to the area called "DIRECTIONALS" and "DIRECTIONALS (HOLD) 8-WAY RUN"... it has four nested tables inside of that table. On the new page, you'll see that the nested tables aren't getting rendered.

[Jaxel]

I think the parser function bug fix created a new bug...

http://www.8wayrun.com/wiki/Talim

There is supposed to be character art on the right... but instead it just says "talSC4art1.jpg"

If you click on the link for "talSC4art1.jpg", it takes you to:
http://www.8wayrun.com/wiki/Image:talSC4art1.jpg_br

It should actually be taking you to:
http://www.8wayrun.com/wiki/Image:talSC4art1.jpg

a "_br" is being added to the end.

[pegasus]

I think the _br issue is this bug: http://www.vaultwiki.org/issues/1910/
It happens when the HTML state changes between template levels.

As for your Directionals table, it would help me determine what the problem was if I could view the source of the article and the templates it uses. This is a new permission in VaultWiki 3, where users can view the source even if you don't want them editing it. If it's simple enough that you can recreate the tables in our demo area, then you can do that, but I'm thinking you might be nesting tables and inserting table parts via templates.

[Jaxel]

Okay, yes, that bug fixed the _br issue...

As for the source code... I've enabled source viewing for registered users. You have an account on my forums right?

[pegasus]

Thanks. Created a report here: http://www.vaultwiki.org/issues/1913/

[Jaxel]

Okay... that fixed it... mostly... still a small issue... I cant get rid of the <br> at the end of the nested tables in the Directionals section. If I try to remove the <br>, the table breaks.

[pegasus]

This occurs when you don't terminate the table with a |-

To fix, edit vault/class/bbcode/table.php. Find:

			$line = trim($line);

Replace with:

			$line = trim($this->parser->strip_front_back_whitespace($line, 1));