I went to check why some of our attachment changes didn't work in VaultWiki 2.5.7 and was unpleasantly surprised to found that VaultWiki uses a lot of vBulletin code, but not in the shared manner - the vB code is just copied to a VaultWiki script or class. For example, the discussion code is actually 95% showthread code. Granted, to make the discussions appear in a tab you indeed have to rip out the main code from showthread, it really couldn't be helped.
But the article postbit class (vB_WikiPost_Factory), why it's defined on its own, why doesn't it inherit from vB_Postbit_Post? Probably a dozen of vB_Postbit_Post class functions such as process_attachments() (my main gripe) had to be duplicated because of that. There had to be a very important reason behind this decision - what was it?
I haven't checked version 3.0, does it follow the same route?
Bookmarks