Issue: Wiki links for pages/synonyms that contain apostrophes

Issue Tools
- View Changes

February 12, 2024 5:04 AM
mazzly

Junior Member
Wiki links for pages/synonyms that contain apostrophes

Example scenario, 3 pages exist:

Harry Potter (synonym: Harry)
Wands (synonym: Wand)
Harry's wand

In texts that contain "... harry's wand ...", the auto-linking won't work for the specific page, and it will instead auto link to the "Harry" and "Wands" pages.

Expectation: It should link to the "Harry's wand" page when that is found in text..

I'm guessing this has something to do with the regex used to split words, but I don't think it should be impossible to solve...

Issue Details

Issue Number 6417

Issue Type Bug

Project VaultWiki 4.x Series

Category BB-Code Parsing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.7

Fixed Version 4.1.8

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags auto-links

February 19, 2024 12:18 PM
pegasus

VaultWiki Team
Assuming the number of pages in your wiki greatly exceeds the number of words in the affected content, you might try this. In src/addons/vw/vw/_core/model/parser/handle/autolink/vw.php. Find:

Code:

[\p{M}\w]+

Replace with:

Code:

[\p{M}\w]+(?:[\-\'][\p{M}\w]+)?

According to tests at regex101 this should additionally capture words that have apostrophe or hyphen in the middle (but not at either end). This should make autolinks now work for possessives or French-language words when there are a large number of wiki pages.
Reply
February 20, 2024 12:26 AM

mazzly

Junior Member

Yep that seems to have fixed it

Will this be in the next release, possibly as an option? I wouldn't want to have to (remember to) apply this fix every time there is a new release..

Reply
February 20, 2024 11:29 AM

pegasus

VaultWiki Team

Unless you tell me in a day or two that you suddenly have unexpected autolink behavior due to the change, I believe this change is safe to release as the standard behavior, since not supporting French elisions was problematic.

Reply

+ Reply

All times are GMT -4. The time now is 6:34 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Wiki links for pages/synonyms that contain apostrophes

Issue Tools