Issue: [4.1.2] VaultWiki removes XF default CSS classes from links (conflicts with feature of another addon)

Issue Tools
- View Changes

July 11, 2021 7:39 AM
ACL

Regular Member
[4.1.2] VaultWiki removes XF default CSS classes from links (conflicts with feature of another addon)

VaultWiki erroneously drops XenForo default CSS classes from posted links. This introduces a conflict with another addon's 'open link in new tab' feature.

By default, XenForo adds some CSS classes to posted links:

"link link--internal" - for links within the same site
"link link--external" - for links to external sites.

As of 4.1.2, all links both internal and external only have the CSS classes " vw-link-self-hash"

Live demo (inspect the link elements): https://www.vaultwiki.org/xf/index.p...937/post-25092

I have a chat addon which forces posted internal links to open in a new tab. It does this by looking for the "link link--internal" classes. This reported VaultWiki issue breaks this chat addon's function.

I've put the brakes on upgrading my public site for now, as I expect losing the 'open link in new tab' to be quite the annoyance for visitors to my site's chat. Are you able to supply a workaround?

Thank you!

Issue Details

Issue Number 6228

Issue Type Bug

Project VaultWiki 4.x Series

Category Styling / CSS

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.2

Fixed Version 4.1.3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

July 11, 2021 7:56 AM
ACL

Regular Member
I can see some changed were made to the following file between 4.1.1 and 4.1.2.

Code:

upload\src\addons\vw\vw\_core\instance\parser\renderer\xf2.php

Making the change below resolves the reported link issue with the chat addon for me, but I've not tested any further. Would this be an acceptable workaround?

On line 1830, find:

Code:

$className = ' vw-link-self-hash';

Replace with:

Code:

$className .= ' vw-link-self-hash';
Reply
July 15, 2021 11:30 PM
pegasus

VaultWiki Team
The problem is that every renderer thinks it is a wiki page. Links in wiki pages are treated differently. Your edit is partially correct because it will also fix the default classes within true wiki pages. But to fix the problem of treating URLs as though they were in wiki pages, edit each src/addons/vw/vw/XF/BbCode/Renderer/*. In each, find:

Code:

if (!empty($this->vwFromWikiTag) AND $this->vwParser)

In each that matches, replace with:

Code:

if (!empty($this->vwFromWikiTag) AND $this->vwParser AND $this->vwParser->for == 'page')
Reply
July 16, 2021 7:19 AM

ACL

Regular Member

Thanks!

Reply

+ Reply

All times are GMT -4. The time now is 6:33 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1.2] VaultWiki removes XF default CSS classes from links (conflicts with feature of another addon)

Issue Tools