Issue: [4.1 Beta 4] User merges don't merge, SQL error: Unknown column 'grantorid' in 'where clause'

Issue Tools
- View Changes

October 30, 2019 4:47 AM

ACL

Regular Member

[4.1 Beta 4] User merges don't merge, SQL error: Unknown column 'grantorid' in 'where clause'

With VW4.1 Beta 4 b003, when attempting to merge two users in XenForo 2.1, the merge does not complete. The following entry is added to the server error log:

XF\Db\Exception: MySQL statement prepare error [1054]: Unknown column 'grantorid' in 'where clause' src/XF/Db/AbstractStatement.php:217

Code:

DELETE FROM `vw_whitelist` WHERE grantorid = 30827 AND userid = 25171
------------

#0 src/XF/Db/Mysqli/Statement.php(196): XF\Db\AbstractStatement->getException('MySQL statement...', 1054, '42S22')
#1 src/XF/Db/Mysqli/Statement.php(39): XF\Db\Mysqli\Statement->getException('MySQL statement...', 1054, '42S22')
#2 src/XF/Db/Mysqli/Statement.php(54): XF\Db\Mysqli\Statement->prepare()
#3 src/XF/Db/AbstractAdapter.php(94): XF\Db\Mysqli\Statement->execute()
#4 src/addons/vw/vw/_core/controller/db/xf2.php(117): XF\Db\AbstractAdapter->query('DELETE FROM `vw...')
#5 src/addons/vw/vw/_core/model/db/mysql/vw.php(1330): vw_DB_Controller_XF2->query_write('DELETE FROM `vw...')
#6 src/addons/vw/vw/_core/model/db/mysql/vw.php(366): vw_DB_MySQL_Model->shutdown_or_run('DELETE FROM `vw...', false)
#7 src/addons/vw/vw/_core/model/plugins/data/vw.php(404): vw_DB_MySQL_Model->delete(Array)
#8 src/addons/vw/vw/XF/Service/User/Merge.php(44): vw_Plugins_Data_Model->do_user_merge_target_required(Array, Array)
#9 src/XF/MultiPartRunnerTrait.php(48): vw\vw\XF\Service\User\Merge->stepMergeWikiUserData(NULL, G)
#10 src/XF/Service/User/Merge.php(88): XF\Service\User\Merge->runLoop(G)
#11 src/XF/Job/UserMerge.php(39): XF\Service\User\Merge->merge(G)
#12 src/XF/Job/Manager.php(253): XF\Job\UserMerge->run(G)
#13 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#14 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#15 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#16 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#17 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#18 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#19 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#20 src/XF/App.php(2178): XF\Mvc\Dispatcher->run()
#21 src/XF.php(390): XF\App->run()
#22 admin.php(13): XF::runApp('XF\\Admin\\App')
#23 {main}

Issue Details

Issue Number 5915

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.1.0 Beta 4

Fixed Version 4.1.0 Beta 4

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 1

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 30, 2019 8:10 AM
pegasus

VaultWiki Team
In src/addons/vw/vw/_core/model/plugins/data/vw.php, find all:

Code:

grantorid

Replace all occurrences with:

Code:

grantor
Reply

October 30, 2019 10:49 AM

ACL

Regular Member

Thanks. With five instances of grantorid changed to grantor, a new SQL error is fired during the user merge:
XF\Db\Exception: MySQL statement prepare error [1054]: Unknown column 'c' in 'where clause' src/XF/Db/AbstractStatement.php:217

N.B. Tester02 is the target username for merge (i.e. after a successful merge, any content for the source account would now belong to Tester02)

Code:

						UPDATE IGNORE `vw_page` SET
							`c` = 3, `r` = 'Tester02'
						WHERE `c` = ?

------------

#0 src/XF/Db/Mysqli/Statement.php(196): XF\Db\AbstractStatement->getException('MySQL statement...', 1054, '42S22')
#1 src/XF/Db/Mysqli/Statement.php(39): XF\Db\Mysqli\Statement->getException('MySQL statement...', 1054, '42S22')
#2 src/XF/Db/Mysqli/Statement.php(54): XF\Db\Mysqli\Statement->prepare()
#3 src/XF/Db/AbstractAdapter.php(94): XF\Db\Mysqli\Statement->execute()
#4 src/XF/Service/User/ContentChange.php(255): XF\Db\AbstractAdapter->query('
						UPDATE I...', 12)
#5 src/XF/MultiPartRunnerTrait.php(48): XF\Service\User\ContentChange->stepReassignContent(57, G)
#6 src/XF/Service/User/ContentChange.php(198): XF\Service\User\ContentChange->runLoop(G)
#7 src/XF/Service/User/Merge.php(137): XF\Service\User\ContentChange->apply(G)
#8 src/XF/MultiPartRunnerTrait.php(48): XF\Service\User\Merge->stepReassignContent(NULL, G)
#9 src/XF/Service/User/Merge.php(88): XF\Service\User\Merge->runLoop(G)
#10 src/XF/Job/UserMerge.php(39): XF\Service\User\Merge->merge(G)
#11 src/XF/Job/Manager.php(253): XF\Job\UserMerge->run(G)
#12 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#13 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#14 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#15 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#16 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#17 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#18 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#19 src/XF/App.php(2178): XF\Mvc\Dispatcher->run()
#20 src/XF.php(390): XF\App->run()
#21 admin.php(13): XF::runApp('XF\\Admin\\App')
#22 {main}

November 4, 2019 7:17 AM
pegasus

VaultWiki Team
In src/addons/vw/vw/XF/Service/User/ContentChange.php, find:

Code:

$xfUpdate[] = $update['username'];

Replace with:

Code:

$xfUpdate[0][] = $update['username'];
Reply
November 4, 2019 8:45 AM

ACL

Regular Member

Thank you. XF2 User merge actions now complete successfully. Wiki content authors mostly appear to be updated correctly (as per issue #5879 resolution) except for one scenario - I'll update the original issue with this information.

Reply

+ Reply

All times are GMT -4. The time now is 7:05 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 4] User merges don't merge, SQL error: Unknown column 'grantorid' in 'where clause'

Issue Tools