vw.php:259

Issue Tools
- View Changes

September 26, 2019 4:24 PM

beernuts

Junior Member

Undefined index: bbcodetag src/addons/vw/vw/_install/lib/common/vw.php:259

Like the title says. Getting that notice in the server error log, completely filling it up

Stacktrace:

Code:

#0 src/addons/vw/vw/_install/lib/common/vw.php(259): vw\vw\Setup\View->handle_php_error(8, 'Undefined index...', '/home/badgerand...', 259, Array)
#1 src/addons/vw/vw/_install/lib/upgradepath/steps/final/xf2.php(34): vw_Install_Common_Controller->do_bbcode(Object(vw\vw\Setup\View))
#2 src/addons/vw/vw/Setup.php(299): vw_Install_UpgradePath_Steps_Final_Controller_XF2->{closure}(Object(vw\vw\Setup\Caller\Upgrade), false)
#3 src/addons/vw/vw/Setup.php(954): vw\vw\Setup->vwRunStep('upgrade', Object(vw_Install_UpgradePath_Steps_Final_Controller_XF2), Array, 2)
#4 src/XF/Admin/Controller/AddOn.php(576): vw\vw\Setup->upgrade(Array)
#5 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\AddOn->actionUpgrade(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(244): XF\Mvc\Dispatcher->dispatchClass('XF:AddOn', 'Upgrade', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\AddOn), NULL)
#7 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\AddOn), NULL)
#8 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2178): XF\Mvc\Dispatcher->run()
#10 src/XF.php(390): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}

Issue Details

Issue Number 5876

Issue Type Bug

Project VaultWiki 4.x Series

Category Install / Upgrade

Status Fixed

Priority 1 - Security / Login / Data Loss

Affected Version 4.1.0 Beta 3

Fixed Version 4.1.0 Beta 3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 26, 2019 4:25 PM

beernuts

Junior Member

Edit: Looks like that notice was generated during the upgrade process.

Reply
September 27, 2019 8:30 AM
pegasus

VaultWiki Team
After looking into this, I believe the cause of this error will lead to the affected BB-Codes not being updated by this upgrade step. Since the upgrade step involves changing the add-on ID from the XF2 add-on to a custom add-on, the BB-Codes will still be associated with the old add-on ID and XenForo will automatically remove them. You may notice that you have no wiki BB-Codes listed in the BB-Code manager.

To regenerate the missing BB-Codes, perform the following steps. In src/addons/vw/vw/_core/controller/cp/area/vw.php, find:

Code:

return $this->reply_view('CP/Area', 'modify');

BEFORE it, add:

Code:

class Fake_View { public function explain() {} } $fv = new Fake_View(); vw_Hard_Core::install('Common')->do_bbcode($fv);

Then visit AdminCP > Wiki > Structures > Area Manager.

After visiting the page, you will notice that XenForo's BB-Code Manager now shows the missing BB-Codes. You can reverse that file edit now.

If you had made custom names for any of the BB-Codes, in the BB-Code Manager, make those changes again.
If you had made custom BB-Codes for specific wiki prefixes, check that those BB-Codes still exist. If they do not, visit the Prefix Manager and recreate them by entering them into the appropriate BB-Code fields.

This error message should now be fixed in build 003, which should prevent similar loss to BB-Codes in future attempts.
Reply
September 27, 2019 8:35 AM

beernuts

Junior Member

In that file, the only place I find that string is inside protected function modify(){}

I can't add a the new Fake_View class inside a method, that'll just result in a 500 error. Am I misunderstanding your instructions?

Reply
September 27, 2019 8:37 AM
pegasus

VaultWiki Team
In that case, please place only this inside the function:

Code:

$fv = new Fake_View(); vw_Hard_Core::install('Common')->do_bbcode($fv);

And at the end of the file, after the closing }, place:

Code:

class Fake_View { public function explain() {} }
Reply
September 27, 2019 8:39 AM

beernuts

Junior Member

OK, Made the edits, loaded the area manager, BB codes show up in the toolbar. Now how do we rebuild the pages so that they actually use the BB code?

Reply
September 27, 2019 10:21 AM

pegasus

VaultWiki Team

The pages you tested were probably already cached while the BB-Codes were missing.
In AdminCP > Wiki > Maintenance > Rebuild Counters / Caches > Cache Parsed Content

Reply
September 27, 2019 10:24 AM

beernuts

Junior Member

Should have mentioned - I already tried that but it didn't work, so I assumed it wasn't the right way to fix it.

Reply
September 27, 2019 10:29 AM

pegasus

VaultWiki Team

That tool assumes you already renamed the appropriate pre-installed BB-Codes and re-entered the prefix BB-Codes as discussed in my earlier post (which are the only things I see not parsing on your site),

If you had made custom names for any of the BB-Codes, in the BB-Code Manager, make those changes again.
If you had made custom BB-Codes for specific wiki prefixes, check that those BB-Codes still exist. If they do not, visit the Prefix Manager and recreate them by entering them into the appropriate BB-Code fields. If they do still exist, check that the Prefix Manager still has them associated with the correct prefixes.

In addition to setting up your prefix BB-Codes, it looks like you also have not changed the name of WIKI to MAIN yet.

Reply
September 27, 2019 10:38 AM

beernuts

Junior Member

Sorry, I literally only visit the wiki to deal with upgrading it. I have no idea what prefixes have been or haven't been created, or anything really aside from upgrading it...I've just re-read your message and it's still not clicking for me.

Can you please just take care of this for me? It's unclear to me exactly what needs to happen. You already have an administrative account on the site (Username Pegasus, email address support@vaultwiki.org)

Reply
September 27, 2019 11:09 AM

pegasus

VaultWiki Team

It looks like some of the issues you are encountering may require VW3 backwards compatibility to be activated in some configs. It is unknown yet whether this works correctly under XenForo 2.

I will need file access in order to activate the backwards compatibility and make any changes needed for it to work correctly in XenForo 2.
Please fill out a ticket: https://www.vaultwiki.org/members/?do=tickets

Reply
September 27, 2019 11:13 AM

beernuts

Junior Member

Well crap. I'll open a ticket.

What is the long-term solution to the VW3 compatibility issue? Will we need to update all of the content to fix it permanently?

Reply
September 27, 2019 2:05 PM

pegasus

VaultWiki Team

The VW3 way of doing some things is still perfectly valid (others not so much), but there is not a lot of robust data from VW3 days (VW3 was only on vBulletin, many years ago now) that made its way onto XF2 to make sure those methods still work under XF2.

Since you already had VW4 before upgrading, you should not be caught by any old VW3-related functionality that was completely removed. If it worked under your previous 4.0 version, we expect it to still work in 4.1.

Reply
September 29, 2019 9:41 AM
ACL

Regular Member
FWIW, I noticed this same 'Undefined index: bbcodetag' item in the admin cp server (php) error log with the XF1.5 version of VaultWiki 4.1 Beta 3 b003 (downloaded 4 days ago). Like the OP, this was triggered during the upgrade process, request state:

Code:

array(3) { ["url"] => string(50) "https://<domain>/admin.php?wiki/upgrade&progress=1" ["_GET"] => array(3) { ["wiki/upgrade"] => string(0) "" ["progress"] => string(1) "1" ["panel"] => string(7) "install" } ["_POST"] => array(4) { ["wiki/upgrade"] => string(0) "" ["progress"] => string(1) "1" ["_xfToken"] => string(8) "********" ["panel"] => string(7) "install" } }

The good news with the XF1 version is that the bbcodes still exist (after upgrading a copy of my public wiki from VW4.0).
Reply
October 4, 2019 9:45 AM

ACL

Regular Member

I've since upgraded a copy of my public wiki to VW4.1 (XF2.1 version) from VW4.1 (XF1.5 version), and the undefined index bbcodetag error was also triggered during this upgrade.

However, the custom bb codes (e.g. wiki, template, file, and others) still show as expected in the admin cp under 'Custom bb codes'. Looking at the xf_bb_code table, the addon_id is set to 'vw/vwcustom'. Everything seems to be fine for me, despite that an undefined index error is triggered multiple times during the upgrade.

Reply

+ Reply

All times are GMT -4. The time now is 12:25 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Undefined index: bbcodetag src/addons/vw/vw/_install/lib/common/vw.php:259

Issue Tools