Issue: [4.1 Beta 3] addon.json version_id and version_string unchanged from Beta 2 ... unable to upgrade 'as-is'

Issue Tools
- View Changes

August 20, 2019 7:24 AM
ACL

Regular Member
[4.1 Beta 3] addon.json version_id and version_string unchanged from Beta 2 ... unable to upgrade 'as-is'

The upload\src\addons\vw\vwaddon.json file in the XF2.1 Beta 3 zip archive has the same contents as XF2.1 Beta 2 b002, even the version id and sting:

Code:

"version_string": "4.1.0 Beta 2", "version_id": 1214010022,

This means that it is not possible to 'upgrade' the addon within XF. I believe that these should be:

Code:

"version_string": "4.1.0 Beta 3", "version_id": 1214010023,

I've made the above changes to addon.json on my offline test site and was then able to start the upgrade. If this were a public site then I wouldn't have made edits to this file (in case I were to hypothetically enter an incorrect version_id and somehow end up skipping future upgrade steps due to my error).

------

Additionally, the URL in the upgrade blockMessage is not quite right as it is currently missing the 'admin.php?' part.

I'm thinking that this could be because vw_general_upgrade is a public template. This template's link is:

Code:

<a href="{{ link('add-ons/vw-vw/upgrade') }}" rel="nofollow">{{ phrase('complete_upgrade') }}</a>

In the standard XenForo public template notice_board_closed, an admin cp link is formatted with a special kind of template function. Perhaps this would address the wrong VW addon upgrade link? E.g.:

Code:

<a href="{{ link_type('admin', 'add-ons/vw-vw/upgrade') }}">

N.B. I have not tested whether this template code would fix the VW addon upgrade link. As I've performed the Beta 3 upgrade already, I no longer see the upgrade notice.

Issue Details

Issue Number 5825

Issue Type Bug

Project VaultWiki 4.x Series

Category Unknown

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 Beta 3

Fixed Version 4.1.0 Beta 3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 1

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 1, 2019 6:31 AM

expanserpb

Junior Member

I changed this and it upgraded but on upgrade the page doing it seemed to get caught in a loop.

Posting an update to the software that doesn't work before a month where no support is provided...

Poor quality processes going on here. Urge to move to another product increasing by the day.

Reply
September 4, 2019 1:14 PM

pegasus

VaultWiki Team

Fixed in the next build.

Reply

+ Reply

All times are GMT -4. The time now is 7:15 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 3] addon.json version_id and version_string unchanged from Beta 2 ... unable to upgrade 'as-is'

Issue Tools