Issue: Bookmarks with Xenforo don't work

Nice find. I just tried this on my offline test site and I experience the same as you - the bookmarks for VW content is not visible. The bookmark item does get saved into the xf_bookmark_item database table.

The issue is that the bookmark_handler_class has not been added for the vwpage content type. I created this with the value 'vw\vw\Handler\Bookmark\Page'. Once this is done, then the bookmarks for standard VW pages appear correctly for me.

---

For the vwspecial content type, I repeated the above albeit with the value 'vw\vw\Handler\Bookmark\Special'. The title includes the HTML characters for the 'Special' prefix. Example:
For the vwrevision content type, some more work is required. As it is, there is an SQL statement error which appears to come from vw\vw\Handler\Bookmark\History::vwFetchPrevious(&$item). But to be honest, I'm not sure why someone would want to bookmark a specific page revision?

I have not checked any further content types.

"The issue is that the bookmark_handler_class has not been added for the vwpage content type. I created this with the value 'vw\vw\Handler\Bookmark\Page'. Once this is done, then the bookmarks for standard VW pages appear correctly for me. "

How can I repeat this?

I've just gone live with the beta now, so my users are basically crazy monkey testing the build now

To add the bookmark_handler_class you'll need to have your site in development mode and then navigate to 'admin.php?content-types/add'.

• Content type: vwpage
• Field: bookmark_handler_class
• Value: vw\vw\Handler\Bookmark\Page
• Add-on: VaultWiki

To enable development, you can follow the instructions at https://xenforo.com/xf2-docs/manual/...velopment-mode

Caution! Development mode unlocks a "Development" section within the admin cp that is only intended for people who develop addons for XenForo. I wouldn't recommend putting a live site in development mode (or if you do anyway, be sure to turn it off asap). When enabled, you can change a lot of things that normally shouldn't be editable, such as parameters for stock XenForo options or even the XenForo version number (which could cause a critical upgrade step to be skipped in the future and potentially break something).

This looks like a bad merge between the development XML and the old Beta 2 XML which already had the bookmark_handler_classes. This will be fixed in the next build. If you already upgraded by modifying addon.json, rebuilding the add-on data on build 002 should work.