Issue: Bug/Conflict

Issue Tools
- View Changes

August 10, 2017 9:43 AM

Hostboard

Junior Member

Bug/Conflict

NON ASCii content

We had an issue as to where characters were not being displayed correctly within posts/threads. In order to resolve there is a one time queries that needs to be triggered to replace those characters and then we found a conflict with VaultWiki BBCode parse plugin area that was debugged and fixed as well.

SQL queries:
UPDATE `post` SET `pagetext` = REPLACE(`pagetext` ,'â€“','–');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€™','\'');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€¦','...');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€“','-');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€œ','"');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€','"');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€˜','\'');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€¢','-');
UPDATE `post` SET `pagetext` = REPLACE(`pagetext`,'â€¡','c');

VaultWiki Conflict correction:

The hook is bbcode_parse_start had this code
it has check for null of $this->instance and this is never null because it is set in the hook itself and so ideally the new code will be what we have here

PHP Code:

if (!class_exists('vB')) { require_once(DIR . '/packages/vw/core.php'); } if (VW_Core::init()) { if (!isset($this->instance)) { $this->instance = vw_Hard_Core::model('Parser')->create($this); } } if ($forumid == 'vw') { if (isset($this->instance) AND $this->instance->get_class() == 'wysiwyg') { vw_Hard_Core::model('Plugins/BBCode/WYSIWYG')->bbcode_parse_start($this, $forumid); } $dobbcode = $this->options['do_bbcode']; $dosmilies = $this->options['do_smilies']; $dobbimagecode = $this->options['do_imgcode']; $dobbvideocode = $this->options['do_videocode']; $dohtml = $this->options['do_html']; $tmp = vw_Hard_Core::model('Plugins/BBCode')->bbcode_parse_start($this, $text, $parsedtext, $forumid, $dobbcode, $dosmilies, $htmlstate == 'off' ? false : $dohtml); if ($parsedtext) { $parsedtext = $tmp; } else { $text = $tmp; } }

Issue Details

Issue Number 5195

Issue Type Bug

Project VaultWiki 4.x Series

Category Forum Posts / Non-Wiki Content

Status Working as Designed

Priority 3 - Loss of Functionality

Affected Version 4.0.18

Fixed Version (none)

Milestone (none)

Software DependencyvBulletin 4.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 11, 2017 11:05 AM

pegasus

VaultWiki Team

In non-wiki content, this change breaks:
- auto-links
- denial of service protection in some BB-Codes
- WYSIWYG editor support for some BB-Codes

For any content, the presence of $this->instance is not guaranteed: during upgrades, it will be null, because VW_Core will not successfully initialize. If users visit non-wiki content during upgrades, and there is no $this->instance check, you will receive fatal errors in non-wiki content while the upgrade is running.

Please reverse the changes you made, as it will cause more problems than it will solve. If there is a particular conflict that the cited code change did resolve, please report what the original conflict was, so that a safe fix can be investigated and created.

For now the original code is marked Working as Designed and will not be changed.

Reply

+ Reply

All times are GMT -4. The time now is 10:45 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Bug/Conflict

Issue Tools