Issue: Saving a template hangs

Issue Tools
- View Changes

March 4, 2016 5:04 PM

Alfa1

Distinguished Member

Saving a template hangs

After editing and saving a css template the page lists all styles that have been saved. But it does not bring me back to the normal admin panel. The top navigation of the admin panel is at the bottom.

Issue Details

Issue Number 4581

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.9

Fixed Version 4.0.10

Milestone (none)

Software DependencyvBulletin 3.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

March 5, 2016 10:25 AM

pegasus

VaultWiki Team

Fixed in the next release.

Reply

March 5, 2016 11:20 AM

pegasus

VaultWiki Team

I have discovered that if you use the Admin Panel > Styles pages in vBulletin 3 to modify templates or stylevars, it only makes the changes to the master copy of that template. This will result in the following problems:

Can only make 1 customized version of the template. All styles would use the same custom version.
The customizations would be erased during the next upgrade.

This is fixed in the next build. In vault/core/controller/cp/style/vb3.php, find:

Code:

		vw_DB::get()->query()->update(array(
			'table' => 'template',
			'set' => array(
				'template' => "'" . vw_DB::get()->func()->escape_string($parsed) . "'",
				'template_un' => "'" . vw_DB::get()->func()->escape_string($value) . "'",
				'dateline' => vw_Hard_Core::controller('Request')->timenow(),
				'username' => "'" . vw_DB::get()->func()->escape_string($username) . "'",
				'version' => "'" . vw_DB::get()->func()->escape_string(vw_Hard_Core::toString()) . "'",
			),
			'where' => vw_DB::get()->query()->eq('templateid', $this->stylevar['templateid']),
			'limit' => 1
		));

Replace with:

Code:

		$values = array(
			'template' => "'" . vw_DB::get()->func()->escape_string($parsed) . "'",
			'template_un' => "'" . vw_DB::get()->func()->escape_string($value) . "'",
			'dateline' => vw_Hard_Core::controller('Request')->timenow(),
			'username' => "'" . vw_DB::get()->func()->escape_string($username) . "'",
			'version' => "'" . vw_DB::get()->func()->escape_string(vw_Hard_Core::toString()) . "'",
		);

		if ($this->style['styleid'] != $this->stylevar['styleid'])
		{
			$values['styleid'] = intval($this->style['styleid']);
			$values['title'] = "'" . vw_DB::get()->func()->escape_string($this->stylevar['varname']) . "'";
			$values['templatetype'] = "'stylevar'";

			vw_DB::get()->query()->insert(array(
				'table' => 'template',
				'values' => array($values)
			));
		}
		else
		{
			vw_DB::get()->query()->update(array(
				'table' => 'template',
				'set' => $values,
				'where' => vw_DB::get()->query()->eq('templateid', $this->stylevar['templateid']),
				'limit' => 1
			));
		}

Find:

Code:

		vw_DB::get()->query()->update(array(
			'table' => 'template',
			'set' => array(
				'template' => "'" . vw_DB::get()->func()->escape_string($parsed) . "'",
				'template_un' => "'" . vw_DB::get()->func()->escape_string($value) . "'",
				'dateline' => vw_Hard_Core::controller('Request')->timenow(),
				'username' => "'" . vw_DB::get()->func()->escape_string($username) . "'",
				'version' => "'" . vw_DB::get()->func()->escape_string(vw_Hard_Core::toString()) . "'"
			),
			'where' => vw_DB::get()->query()->eq('templateid', $this->template['templateid']),
			'limit' => 1
		));

Replace with:

Code:

		$values = array(
			'template' => "'" . vw_DB::get()->func()->escape_string($parsed) . "'",
			'template_un' => "'" . vw_DB::get()->func()->escape_string($value) . "'",
			'dateline' => vw_Hard_Core::controller('Request')->timenow(),
			'username' => "'" . vw_DB::get()->func()->escape_string($username) . "'",
			'version' => "'" . vw_DB::get()->func()->escape_string(vw_Hard_Core::toString()) . "'",
		);

		if ($this->style['styleid'] != $this->template['styleid'])
		{
			$values['styleid'] = intval($this->style['styleid']);
			$values['title'] = "'" . vw_DB::get()->func()->escape_string($this->template['varname']) . "'";
			$values['templatetype'] = "'template'";

			vw_DB::get()->query()->insert(array(
				'table' => 'template',
				'values' => array($values)
			));
		}
		else
		{
			vw_DB::get()->query()->update(array(
				'table' => 'template',
				'set' => $values,
				'where' => vw_DB::get()->query()->eq('templateid', $this->template['templateid']),
				'limit' => 1
			));
		}

+ Reply

All times are GMT -4. The time now is 12:23 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Saving a template hangs

Issue Tools