Issue: Still getting those HTML quote parsing error things

Issue Tools
- View Changes

August 1, 2013 8:08 PM

Morrus

Regular Member

Still getting those HTML quote parsing error things

Apologies - I know there's a thread for this, but I couldn't find it.

Anyhow, emails still contain a whole mess of HTML code referencing vw. Here's an example I just got:

Dear Morrus,

Umbran has quoted you!

-----------

<div class="bbcode_container">
<div class="bbcode_quote">
<div class="quote_container">
<div class="bbcode_quote_container"></div>

<div class="bbcode_postedby">
<img src="http://www.enworld.org/forum/images/Styles/Blackend/misc/quote_icon.png" alt="Quote" /> Originally Posted by <strong>Morrus</strong>
<a href="http://www.enworld.org/forum/showthread.php?p=6164951#post6164951" rel="nofollow"><img class="inlineimg" src="images/Styles/Blackend/buttons/viewpost-right.png" alt="View Post" /></a>
</div>
<div class="message">He's in the 50th anniversary special in November as a "forgotten/hidden" incarnation between Paul McGann and Christopher Ecclestone who did bad stuff and got disowned - at least that's what it looks like so far.</div>

</div>
</div>
</div>
The shots I had seen showed him in the same costume as McGann - that typically means it is the same Doctor, or a new Doctor just after his regeneration

Issue Details

Issue Number 3276

Issue Type Bug

Project VaultWiki 4.x Series

Category BB-Code Parsing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.0 Beta 4

Fixed Version 4.0.0 Beta 5

Milestone VaultWiki 4 Beta X

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 1, 2013 9:08 PM

pegasus

VaultWiki Team

I need to know what mod you're using to send these QUOTE notifications so I can run some local tests.

Reply
August 2, 2013 12:18 PM

Morrus

Regular Member

It's Dragonbyte Tech's user tagging mod.

Reply
August 2, 2013 5:21 PM

Testuser

New Member

Originally Posted by pegasus

I need to know what mod you're using to send these QUOTE notifications so I can run some local tests.

Ah, it's that mod again.

Reply
August 2, 2013 5:25 PM
pegasus

VaultWiki Team
Tried with the user tagging mod installed. When I got the quote email, it was parsed correctly. There was no HTML or anything unexpected:

Code:

Dear pegasus, Testuser has quoted you! ----------- ---Quote (Originally by pegasus)--- I need to know what mod you're using to send these QUOTE notifications so I can run some local tests. ---End Quote--- Ah, it's that mod again. -----------

The only thing I can think of is if you use a PHP cache or accelerator, you may need to reset it.
Reply
August 3, 2013 12:52 PM

Morrus

Regular Member

Originally Posted by pegasus

The only thing I can think of is if you use a PHP cache or accelerator, you may need to reset it.

Tried that. And tried restarting web server software. No change.

Reply
August 5, 2013 6:29 PM

Morrus

Regular Member

OK, so which template is it that's overwritten? What will happen if I revert that template? Should that not fix the issue? what part of vaultwiki would stop working if I did that?

Reply
August 5, 2013 11:16 PM

pegasus

VaultWiki Team

It has nothing to do with templates. VaultWiki overrides the callback function for QUOTE tags, so that you can also quote wiki content. But for some reason VaultWiki isn't able to detect when your site is using the plain-text version, so the wrong callback gets used. I will have to run some tests against your site to find out what's wrong, and send some fake notifications to myself until I can resolve it.

Reply
August 6, 2013 8:01 AM

Morrus

Regular Member

I'm not desperately worried about people being able to quote wiki content. Losing that vs. gaining quote emails back is an easy win.

Reply
August 6, 2013 11:07 AM

pegasus

VaultWiki Team

Fixed in the next release and on your site. This occurred for any BB-Code with a plain-text (or other version) when more than one version of the parser is used during the same request. The classes for the callbacks are cached, which leads to reusing the callback from a different version.

Obviously this can have more effects than just on notification emails. The problem was also not limited to just vBulletin.

Reply
August 6, 2013 6:34 PM

Morrus

Regular Member

Awesome! Thanks!

Reply

+ Reply

All times are GMT -4. The time now is 7:02 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Still getting those HTML quote parsing error things

Issue Tools