Issue: Wiki articles are getting locked when they shouldn't be

In the database, does your 'post' table have a column called "pending"?

Were the edits in question "section" edits, where the user only modified a segment of the article?

In either case, it's possible that the "pending" field is populated unnecessarily. In vault/tabs/special_tab_edit.php, find:
Add below:

No, there is no column called "pending" in the post table.

I think they are section edits: "#
(new) (last) 15th December 2009, 02:02 USERNAME (contribs)(5,916 bytes)(approve)
→ The order list"

We have found out that the problem is caused by users who are under moderation in the regular forum changing wiki pages. As most of our users are under moderation (first few posts, until they prove themselves), this is where the problem is coming from. Is it possible to turn off the requirement for having posts moderated by these users in the wiki?

Interestingly, this still doesn't explain the problem that (a) the moderators panel has no wiki moderation approval page (b) In the admin panel "Wiki Edits Awaiting Moderation" has nothing in it (this is while, now, for example, there is a locked wiki page).

I made the change you suggested, however when I try to edit the article I still get "You cannot edit this article at this time because there is currently a previous edit awaiting approval.".

After this, I tried to approve the change, and selected "approve". It then said "The change has not been approved", and reverted to the wiki page however it looks like the approval has now gone away. This was also a problem in the previous version of vault we had - that you choose to approve and it says "The change has not been approved".

The edit I gave you above would not change the approval, it would just prevent other data from being carried over to the "pending" field during a section edit.

Thanks for investigating this further. I should be able to do something about this with the new information.

Okay, so far I have fixed the "Wiki Moderation" item missing from the ModCP nav, and fixed the "The change has not been approved" (the message actually lies). Plugged a number of holes where moderated users can actually bypass the moderation checks -- wiki permissions now consider infraction-group (negative) permissions.

But I have been unable to locate anywhere that the Forum Moderation Rules override the Wiki Edit Moderation rules -- however, keep in mind that if the forum has Custom Forum Permissions, those will overwrite the standard Usergroup Permissions. If the group that is having problems has custom permissions for the wiki forum, make sure that the wiki permissions (listed in the forum permissions edit window) are also correct (Forums & Moderators > Forum Permissions).

I have not been able to reproduce the Wiki Moderation page being empty when changes need approval.

If either of these remaining issues persist, you can PM me about having a look at your installation and attempting to find a fix directly.

It's still happening.

* Nothing in Admin->CES VaultWiki->Wiki Moderation
* All forum moderation rules for the wiki forum are set to "No"
* User is a new user that requires moderation forum-wide
* The table.column vault_revision.pending for that revision is set to 1
* The forum permissions "Follow Edit Moderation Rules" is set to Yes

I could run a cron job every minute to set all pending=1 to pending=0 in that table? Is there a new version?

There appears to be no way to PM you - clicking your avatar gives "This user has not registered and therefore does not have a profile to view."

There's a new version. It's a beta, but a new version nonetheless, where a number of moderation bugs were fixed. We were never able to reproduce this so I don't want to get your hopes up, but of course you can try it.

Ideally it would be best if this issue could be solved, but I realize this is happening to you on a live board, so yes, the cron job could be a stop-gap for you (vault_article.pending would also be set to 1 for the threadid).

Sorry about not being able to PM me. This appears to be a bug with vbSEO that happens almost randomly. Try: http://www.vaultwiki.org/private.php?do=newpm&u=1

I'm not running this every minute, which I hope will fix the problem? "update vault_revision set pending = 0;update vault_article set pending = 0;"

Yes, that will help hide the problem, but it won't fix the underlying issue. As mentioned earlier, if you can arrange for me to look at your AdminCP it should aid me in reproducing this on a test board and finding a real fix. Please use the link in my previous post to PM me about this.

In response to the PM where you've asked me to provide details here:

On my wiki I've got the main Editors setup with full permissions, and registered users with more restricted permissions. I've only seen this because a few more regular users have got in on creating articles, but they can edit existing ones fine (hence why the Article Titles springs to mind).

My settings for my Registered users are:

Can edit wiki articles? Yes
Can view source of wiki pages? Yes
Can view article history? Yes
Can protect wiki articles? No
Can restore wiki articles to previous versions? No
Can edit article titles? No
Follow Edit Moderation Rules? Yes
Can modify wiki page language settings? No

Feel free to check out the settings direct.

I have checked that the group has permissions to post in the forum (and it's parent forums) and they have. So really unsure why this crops up.

Not sure now that this had much to do with the OP. Check your Forum Manager. For the forum in question, you probably have "Moderate New Threads" checked. This is a feature of vBulletin that adds all new threads to the moderation queue unless the user is a moderator or higher.

Regarding the OP, I have never been able to reproduce this. Depending on the version of vBulletin you're running, it's possible there's a bug in vBulletin where it doesn't consistently retain the bitfield settings. There haven't been any significant changes to permissions calculation in VaultWiki 3, so it's likely this bug would persist. However, I've been over this time and time again, duplicating your settings, but just can't get it to happen on any tests. Since you haven't followed up in several months, I'm assuming the problem has dissipated.

I've checked the forum and forums in question (i.e. parent forums) none of them are set to moderate new threads, all are open for posting, all have permissions for registered users to post, with the only difference between my Wiki User group and the Registered users being this (in the VaultWiki settings):

Can protect wiki articles?
Can restore wiki articles to previous versions?
Can edit article titles?
Can modify wiki page language settings?

All these are set to no for the registered users.

Follow Edit Moderation Rules is set to Yes.

What is the forum in question? I checked your Reviews forum before and it was set to Moderate New Threads.

It's the main Wiki forum.

Does this happen consistently with Registered Users or randomly? I tried changing my permissions to Registered Users and still not getting this.