• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 3.x Series
    • Bug
    • Wiki articles are getting locked when they shouldn't be

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: Wiki articles are getting locked when they shouldn't be

    • Issue Tools
      • View Changes
    1. issueid=965 December 16, 2009 10:10 AM
      diyaudio diyaudio is offline
      New Member
      Wiki articles are getting locked when they shouldn't be
      Users who shouldn't need to have edits approved are having their edits lock wiki pages until they are approved by an administrator, causing nobody else to be able to edit them in the meantime

      I'm having a repeating problem with Vaultwiki (latest version). It was the same with the old version we were on (2.5.3?) and after upgrading to 2.5.7 it persists, and we're having the problem reoccur.

      I have good screenshots of the problem but sadly I can't attach them to this post.

      No user edits require moderator approval. However somehow they are requiring to be approved (sometimes)! The wiki article can't be edited by regular users it is approved (very annoying!). The page isn't protected.

      The usergroup who made the edit has the following permissions:

      Can edit wiki articles - yes
      view history - yes
      protect articles - no
      restore articles to prev version - no
      edit titles - no
      follow edit moderation rules - yes

      Additionally, while this page is locked, the "wiki edits awaiting moderation" page in the VB admin shows no wiki edits awaiting moderation.

      Any ideas? We're at wits end!
    Issue Details
    Issue Number 965
    Issue Type Bug
    Project VaultWiki 3.x Series
    Category Editing / Posting Articles
    Status Fixed
    Priority 4 - Warnings / Script Errors
    Affected Version 2.5.7
    Fixed Version 3.0.0 RC 1
    Milestone VaultWiki 3.0.0
    Software DependencyAny
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)


    Page 1 of 2 12 Next LastLast


    1. December 16, 2009 11:07 AM
      pegasus pegasus is offline
      VaultWiki Team
      In the database, does your 'post' table have a column called "pending"?

      Were the edits in question "section" edits, where the user only modified a segment of the article?

      In either case, it's possible that the "pending" field is populated unnecessarily. In vault/tabs/special_tab_edit.php, find:
      Code:
      			$dataman->setr('pagetext', $edit['message']);
      Add below:
      Code:
      			$edit['pending'] = false;
      Reply Reply  
    2. December 17, 2009 10:55 AM
      diyaudio diyaudio is offline
      New Member
      No, there is no column called "pending" in the post table.

      I think they are section edits: "#
      (new) (last) 15th December 2009, 02:02 USERNAME (contribs)(5,916 bytes)(approve)
      → The order list"

      We have found out that the problem is caused by users who are under moderation in the regular forum changing wiki pages. As most of our users are under moderation (first few posts, until they prove themselves), this is where the problem is coming from. Is it possible to turn off the requirement for having posts moderated by these users in the wiki?

      Interestingly, this still doesn't explain the problem that (a) the moderators panel has no wiki moderation approval page (b) In the admin panel "Wiki Edits Awaiting Moderation" has nothing in it (this is while, now, for example, there is a locked wiki page).

      I made the change you suggested, however when I try to edit the article I still get "You cannot edit this article at this time because there is currently a previous edit awaiting approval.".
      Reply Reply  
    3. December 17, 2009 10:57 AM
      diyaudio diyaudio is offline
      New Member
      After this, I tried to approve the change, and selected "approve". It then said "The change has not been approved", and reverted to the wiki page however it looks like the approval has now gone away. This was also a problem in the previous version of vault we had - that you choose to approve and it says "The change has not been approved".
      Reply Reply  
    4. December 18, 2009 12:55 AM
      pegasus pegasus is offline
      VaultWiki Team
      The edit I gave you above would not change the approval, it would just prevent other data from being carried over to the "pending" field during a section edit.

      Thanks for investigating this further. I should be able to do something about this with the new information.
      Reply Reply  
    5. December 18, 2009 2:53 AM
      pegasus pegasus is offline
      VaultWiki Team
      Okay, so far I have fixed the "Wiki Moderation" item missing from the ModCP nav, and fixed the "The change has not been approved" (the message actually lies). Plugged a number of holes where moderated users can actually bypass the moderation checks -- wiki permissions now consider infraction-group (negative) permissions.

      But I have been unable to locate anywhere that the Forum Moderation Rules override the Wiki Edit Moderation rules -- however, keep in mind that if the forum has Custom Forum Permissions, those will overwrite the standard Usergroup Permissions. If the group that is having problems has custom permissions for the wiki forum, make sure that the wiki permissions (listed in the forum permissions edit window) are also correct (Forums & Moderators > Forum Permissions).

      I have not been able to reproduce the Wiki Moderation page being empty when changes need approval.

      If either of these remaining issues persist, you can PM me about having a look at your installation and attempting to find a fix directly.
      Reply Reply  
    6. January 7, 2010 7:17 AM
      diyaudio diyaudio is offline
      New Member
      It's still happening.

      * Nothing in Admin->CES VaultWiki->Wiki Moderation
      * All forum moderation rules for the wiki forum are set to "No"
      * User is a new user that requires moderation forum-wide
      * The table.column vault_revision.pending for that revision is set to 1
      * The forum permissions "Follow Edit Moderation Rules" is set to Yes

      I could run a cron job every minute to set all pending=1 to pending=0 in that table? Is there a new version?

      There appears to be no way to PM you - clicking your avatar gives "This user has not registered and therefore does not have a profile to view."
      Reply Reply  
    7. January 7, 2010 11:48 AM
      pegasus pegasus is offline
      VaultWiki Team
      There's a new version. It's a beta, but a new version nonetheless, where a number of moderation bugs were fixed. We were never able to reproduce this so I don't want to get your hopes up, but of course you can try it.

      Ideally it would be best if this issue could be solved, but I realize this is happening to you on a live board, so yes, the cron job could be a stop-gap for you (vault_article.pending would also be set to 1 for the threadid).

      Sorry about not being able to PM me. This appears to be a bug with vbSEO that happens almost randomly. Try: http://www.vaultwiki.org/private.php?do=newpm&u=1
      Reply Reply  
    8. January 15, 2010 12:47 AM
      diyaudio diyaudio is offline
      New Member
      I'm not running this every minute, which I hope will fix the problem? "update vault_revision set pending = 0;update vault_article set pending = 0;"
      Reply Reply  
    9. January 15, 2010 1:18 AM
      pegasus pegasus is offline
      VaultWiki Team
      Yes, that will help hide the problem, but it won't fix the underlying issue. As mentioned earlier, if you can arrange for me to look at your AdminCP it should aid me in reproducing this on a test board and finding a real fix. Please use the link in my previous post to PM me about this.
      Reply Reply  
    10. April 21, 2010 1:37 AM
      Mokonzi Mokonzi is offline
      Senior Member
      In response to the PM where you've asked me to provide details here:

      I've been looking over my permissions system, and for some reason, my Registered users are ending up with moderated articles. The only thing I can see causing this is the option for Can Edit Article Titles, which is set to no. Is that what is causing the problem? Is that what it's meant to do?
      On my wiki I've got the main Editors setup with full permissions, and registered users with more restricted permissions. I've only seen this because a few more regular users have got in on creating articles, but they can edit existing ones fine (hence why the Article Titles springs to mind).

      My settings for my Registered users are:

      Can edit wiki articles? Yes
      Can view source of wiki pages? Yes
      Can view article history? Yes
      Can protect wiki articles? No
      Can restore wiki articles to previous versions? No
      Can edit article titles? No
      Follow Edit Moderation Rules? Yes
      Can modify wiki page language settings? No

      Feel free to check out the settings direct.

      I have checked that the group has permissions to post in the forum (and it's parent forums) and they have. So really unsure why this crops up.
      Reply Reply  
    11. April 21, 2010 1:17 PM
      pegasus pegasus is offline
      VaultWiki Team
      Not sure now that this had much to do with the OP. Check your Forum Manager. For the forum in question, you probably have "Moderate New Threads" checked. This is a feature of vBulletin that adds all new threads to the moderation queue unless the user is a moderator or higher.

      Regarding the OP, I have never been able to reproduce this. Depending on the version of vBulletin you're running, it's possible there's a bug in vBulletin where it doesn't consistently retain the bitfield settings. There haven't been any significant changes to permissions calculation in VaultWiki 3, so it's likely this bug would persist. However, I've been over this time and time again, duplicating your settings, but just can't get it to happen on any tests. Since you haven't followed up in several months, I'm assuming the problem has dissipated.
      Reply Reply  
    12. April 21, 2010 1:25 PM
      Mokonzi Mokonzi is offline
      Senior Member
      I've checked the forum and forums in question (i.e. parent forums) none of them are set to moderate new threads, all are open for posting, all have permissions for registered users to post, with the only difference between my Wiki User group and the Registered users being this (in the VaultWiki settings):

      Can protect wiki articles?
      Can restore wiki articles to previous versions?
      Can edit article titles?
      Can modify wiki page language settings?


      All these are set to no for the registered users.

      Follow Edit Moderation Rules is set to Yes.
      Reply Reply  
    13. April 21, 2010 2:18 PM
      pegasus pegasus is offline
      VaultWiki Team
      What is the forum in question? I checked your Reviews forum before and it was set to Moderate New Threads.
      Reply Reply  
    14. April 21, 2010 3:24 PM
      Mokonzi Mokonzi is offline
      Senior Member
      It's the main Wiki forum.
      Reply Reply  
    15. April 21, 2010 4:07 PM
      pegasus pegasus is offline
      VaultWiki Team
      Does this happen consistently with Registered Users or randomly? I tried changing my permissions to Registered Users and still not getting this.
      Reply Reply  
    Page 1 of 2 12 Next LastLast
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 4:36 PM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2023 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2023 DragonByte Technologies Ltd.
    Copyright © 2008 - 2013 VaultWiki Team, Cracked Egg Studios, LLC.