Issue: Anchors Don't Follow Encode Rules

Issue Tools
- View Changes

October 1, 2009 3:19 PM

pegasus

VaultWiki Team

Anchors Don't Follow Encode Rules

When using the H tag to create sections, the anchors created by them and pointed to by the article's table of contents don't follow the same URL rules as article titles. This is inconsistent and can lead to ugly URLs (with anchors).

Additionally, when using additional parameters in wiki link BB-Codes to create query strings and add anchors, the query string is encoded using the wiki's URL rules, which can corrupt non-article-title strings.

Fixed for the next build. In vault/special_plugins_bbcode.php, find:

Code:

				if ($first['char'] == '#')
				{
					$anchor = '#' . $vault->anchorify(strip_tags($first['bit']));
				}
				else
				{
					$urlpieces[0] = $vault->urlencode($urlpieces[0]);
					$entry = $vault->urlencode($entry);
					$requests .= "&amp;" . $urlpieces[0] . (!empty($entry) ? "=$entry" : '');
				}

Replace with:

Code:

				if ($first['char'] == '#')
				{
					$anchor = '#' . $vault->urlencode(strip_tags($first['bit']));
				}
				else
				{
					$urlpieces[0] = urlencode($urlpieces[0]);
					$entry = urlencode($entry);
					$requests .= "&amp;" . $urlpieces[0] . (!empty($entry) ? "=$entry" : '');
				}

Find:

Code:

	$anchor_name = $vault->anchorify($header_title);

Replace with:

Code:

	$anchor_name = $vault->urlencode($header_title);

Issue Details

Issue Number 861

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 2.5.4

Fixed Version 2.5.5

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

+ Reply

All times are GMT -4. The time now is 12:22 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Anchors Don't Follow Encode Rules

Issue Tools