Issue: Entities Not Stripped from URL

Issue Tools
- View Changes

October 1, 2009 3:11 PM
pegasus

VaultWiki Team
Entities Not Stripped from URL

The first URL on the page, which is the article when viewing an article, only removes entities if there is a URL replacement set for the current language. Additionally, if any other URL on the page contains HTML entities, they will not be stripped before being encoded.

Fixed for the next build. $vbulletin is not available in the scope of the URL builder. Moved the conditional to inside the cleaner. Use $haslang instead to check for existing replacements.

In vault/special_class_wiki.php, find:

Code:

static $badchars, $replacer;

Replace with:

Code:

static $badchars, $replacer, $haslang;

Find:

Code:

$replacer["$langid"]["$lookup[0]"] = $lookup[1];

Add after:

Code:

$haslang["$langid"] = $langid;

Find:

Code:

if (!empty($vbulletin->options['vault_replaces']["$langid"])) { $text = preg_replace('#&\#?\w+;#e', '\$this->replace_test(\$replacer[' . $langid . '], "\0");', $text); }

Replace with:

Code:

$text = preg_replace('#&\#?\w+;#e', '\$this->replace_test(' . ($haslang["$langid"] ? '\$replacer[' . $langid . ']' : 'array()') . ', "\0");', $text);

Issue Details

Issue Number 860

Issue Type Bug

Project VaultWiki 3.x Series

Category Wiki Pages

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 2.5.4

Fixed Version 2.5.5

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

+ Reply

All times are GMT -4. The time now is 10:41 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Entities Not Stripped from URL

Issue Tools