Issue: Order of Broken Table Templates

Issue Tools
- View Changes

September 30, 2009 10:39 AM
Jaxel

Junior Member
Order of Broken Table Templates

Yeah...

I have the following template: 4columnSTR

Code:

[if={{{t}}}][table] class="tborder" style="text-align: center;border-bottom:0px;" border="0" cellpadding="6" cellspacing="1" width="{{{w|88.5%}}}" |- | class="tcat" | {{{t}}} [/table][/if][table] class="tborder [if={{{s}}}]sortable[/if]" style="text-align: center;[if={{{t}}}]border-top:0px;[/if]" border="0" cellpadding="6" cellspacing="1" width="{{{w|88.5%}}}" |- | class="thead" | {{{1}}} | class="thead" | {{{2}}} | class="thead" | {{{3}}} | class="thead" | {{{4}}}

Called up using the following code:

Code:

[template]4columnSTR| ATTACK | COMMAND | PUNISH | NOTES | t=Seong Mi-na: Punishing Algol[/template]

By design, a tcat table should be played above the main table, since {{{t}}} exists. However, this is failing. Instead of the table being placed before the main table code as its supposed to, it is being placed at the END of the main table code... which puts the tcat table INSIDE the {{{4}}} thead. Example on this link:

http://www.8wayrun.com/wiki/How_Do_You_Create_Tables

Look at the first table on that page. See how there is a table under "NOTES"? That table is supposed to be ABOVE the table, and span the same width as the 4 columns. This is how it worked in 2.5.3...

Issue Details

Issue Number 857

Issue Type Bug

Project VaultWiki 3.x Series

Category Templates

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 2.5.4

Fixed Version 2.5.5

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 30, 2009 1:10 PM
pegasus

VaultWiki Team
Fixed for the next build.

This is another nesting issue in 2.5.3 and 2.5.4 (that you didn't notice because you had reverted to a 2.5.2 version of the file, and that we didn't notice because the test template you originally gave us didn't have the TCAT in a separate TABLE).

A general note: This only occurs for TABLE templates that don't include both the opening and closing tag in the same template. vBulletin doesn't like this practice at all, so we are trying to hide it from vBulletin as best we can. Remember you can avoid similar issues by avoiding BB-Code fragments in general.

Even though you don't like file edits, I'm required to post them in case other users have the same issue. In vault/special_class_bbcode.php, find:

Code:

$this->node_num++;

Add after:

Code:

if ($node['name'] == 'noedit') { continue; }

This essentially skips the line break fix added in 2.5.4. The following moves the fix so it still does its job. Find:

Code:

if ($node['name'] != 'noedit') { $parse_options['strip_space_after'] = 0; }

Replace with:

Code:

$parse_options['strip_space_after'] = 0;
Reply
October 1, 2009 3:19 PM

Jaxel

Junior Member

This bug actually sounds logical...

but if you can't do code fragments, then there really isn't a point of templates in general..

Reply

+ Reply

All times are GMT -4. The time now is 5:08 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Order of Broken Table Templates

Issue Tools