Issue: VaultWiki 2.5.1 prevents thread merges

Issue Tools
- View Changes

August 29, 2009 9:25 PM

Will.Spencer Will.Spencer is offline

Junior Member

VaultWiki 2.5.1 prevents thread merges

After upgrading to 2.5.1, moderators can no longer merge threads

After upgrading to 2.5.1, my moderators can no longer merge vBulletin threads.

Here's the error I receive via email when this happens:

Code:

Database error in vBulletin 3.8.4:

Invalid SQL:

                SELECT postid, thread.threadid, firstpostid
                        
                FROM post AS post
                LEFT JOIN thread AS thread ON (post.threadid = thread.threadid)
                WHERE post.id IN (7133,7022);

MySQL Error   : Unknown column 'post.id' in 'where clause'
Error Number  : 1054
Request Date  : Saturday, August 29th 2009 @ 07:18:48 PM
Error Date    : Saturday, August 29th 2009 @ 07:18:48 PM
Script        : http://www.netbuilders.org/inlinemod.php?do=domergethreads&threadids=7133,7022
Referrer      : http://www.netbuilders.org/inlinemod.php?forumid=1
IP Address    : 106.102.91.107
Username      : m42
Classname     : vB_Database_MySQLi
MySQL Version : 5.0.45-log

The effects thread merges in normal non-VaultWiki forums.

If I disable VaultWiki, everything works fine.

Have you seen this odd behavior before?

Issue Details

Issue Number 808

Issue Type Bug

Project VaultWiki 3.x Series

Category Unknown

Status Duplicate

Priority 2 - Fatal / Database Errors

Affected Version 2.5.1

Fixed Version (none)

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 29, 2009 9:59 PM

Will.Spencer Will.Spencer is offline

Junior Member

The offending code appears to be in vault/special_plugins_inlinemod.php:

Code:

        $interior_posts = $db->query_read("
                SELECT postid, thread.threadid, firstpostid
                        " . ($getforumids ? ", forumid, prefixid, thread.title" : "") . " 
                FROM " . TABLE_PREFIX . "post AS post 
                LEFT JOIN " . TABLE_PREFIX . "thread AS thread ON (post.threadid = thread.threadid)
                WHERE post." . $db->escape_string($type) . "id IN (" . implode(',', $threadarray) . ")
        ");

If I remove the first period from line 406, thread merges work again.

But we still get this error:

Code:

[Warning: Missing argument 2 for special_inlinemod_start(), called in [path]/inlinemod.php(383) : eval()'d code on line 5 and defined in [path]/vault/special_plugins_inlinemod.php on line 362]

August 30, 2009 3:41 AM

pegasus

VaultWiki Team

Depending on the method you use to merge threads, this is a duplicate of:
http://www.crackedeggstudios.com/issues/797/
or
http://www.crackedeggstudios.com/issues/802/

and
http://www.crackedeggstudios.com/issues/799/

Reply
August 30, 2009 12:12 PM

Will.Spencer

Junior Member

I've applied the fixes from those threads. Hopefully everything will hold together until 2.5.2!

Reply

September 3, 2009 10:29 AM

optikalefx optikalefx is offline

Junior Member

2.5.2 didn't seem to fix it. I made my own fix, any know if this may cause other errors down the line?

special_plugins_inlinemod.php
line 365
change:

Code:

function special_inlinemod_start($threadids, $type, $getforumids = false)

Code:

function special_inlinemod_start($threadids)

and then changed

Code:

$interior_posts = $db->query_read("
		SELECT postid, thread.threadid, firstpostid
			" . ($getforumids ? ", forumid, prefixid, thread.title" : "") . "
		FROM " . TABLE_PREFIX . "post AS post
		LEFT JOIN " . TABLE_PREFIX . "thread AS thread ON (post.threadid = thread.threadid)
		WHERE post." . $db->escape_string($type) . "id IN (" . implode(',', $threadarray) . ")
	");

to:

Code:

$interior_posts = $db->query_read("
		SELECT postid, thread.threadid, firstpostid
			" . ($getforumids ? ", forumid, prefixid, thread.title" : "") . "
		FROM " . TABLE_PREFIX . "post AS post
		LEFT JOIN " . TABLE_PREFIX . "thread AS thread ON (post.threadid = thread.threadid)
		WHERE postid IN (" . implode(',', $threadarray) . ")
	");

September 3, 2009 2:07 PM

pegasus

VaultWiki Team

Yes. Without the type differentiation you can run into issues when doing anything from the "Thread Tools" menu or the inline moderation from forumdisplay. I just checked the package for 2.5.2 and all the appropriate changes are there, so I'm not sure what "2.5.2 didn't seem to fix" for you. Did you remember to run the upgrade script (/vault/install/upgrade.php)?

Reply

+ Reply

All times are GMT -4. The time now is 8:47 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: VaultWiki 2.5.1 prevents thread merges

Issue Tools