Issue: Problems uploading images

Issue Tools
- View Changes

August 8, 2009 1:44 PM

vimto

Regular Member

Problems uploading images

Image uploading into a thumbnail instead of the full size

This is similar to what I've reported before, but seems to have come back stronger.

When I'm uploading an image it seems to upload it into a thumnail size rather than the full size.
I've changed the settings in the vbulletin options on Thumbnail Creation to "No" and tried uploading again, but still the image is being uploaded into a thumbnail instead of the full image...

I've checked the max image size and file size settings in the admin panel but these check out ok.

I managed to upload an image last night to full size, but this was on the 3rd attempt and I'm not sure what I did different to make it upload correctly.
I normally head to the image namespace, create a new article with the name of the image, i.e. vimto.jpg then I manage attachments and upload the image. This is where the resulting image has been shrunk to a thumbnail and the filesize reduced.

Today I've tried with 3 different images and each one has uploaded as a thumnail......

Issue Details

Issue Number 757

Issue Type Bug

Project VaultWiki 3.x Series

Category Images

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 2.5.0

Fixed Version 2.5.1

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 8, 2009 3:41 PM

pegasus

VaultWiki Team

This problem occurs on your server in non-wiki posts and even with VaultWiki Images disabled. This leads me to believe this is a configuration problem on your server:

When uploading a gif, it is converted to a jpg of smaller dimensions. According to vBulletin's class_image.php, this only occurs when the function getimagesize() returns false.

There was, however, a problem where uploading an image with dimensions higher than the max allowed as a wiki image would upload it as a thumbnail. I have fixed this for the next build, but it won't have any effect on your main issue.

Reply
August 9, 2009 4:55 AM

vimto

Regular Member

I just uploaded an image as an attachment into my test forum and it uploaded as full size, but when I tried to upload into the wiki images it shrank it again........

any idea which configuration it is that needs looking at?

Reply
August 9, 2009 1:59 PM
pegasus

VaultWiki Team
Ah, perhaps it is something else.

Currently you have a maximum height setting of 280 px for most image types. As many tests may exceed that, this may contribute, and have given a false positive in non-wiki forums with the mod disabled. Therefore, it's very likely that you are getting the issue where:

Uploading an image with dimensions higher than the max allowed as a wiki image would upload it as a thumbnail.

However, you have a max of 0 for jpg files, so technically this should all be skipped when uploading a file with the jpg extension. However, there is still a max file size setting for jpg files, so if the file size is exceeded, the image will be resized and trigger the bug mentioned above. Uploading a jpg within the set max file size will be uploaded correctly.

I was mistaken above when I said that the jpg conversion must be a server configuration problem. Further investigation reveals that vBulletin will convert the image to a jpg when resizing is needed (this will be particularly annoying in the image forum where the title has to match, and some users might not have permission to modify the title at this point).

To fix the main problem, in vault/extensions/image/image_class_thumb.php, perform the following replacement in 2 places. Find:

Code:

$vault_dimensions = explode(',', $this->registry->options['vaulti_thumb_width']); $maxwidth = intval($vault_dimensions[0]); $maxheight = intval($vault_dimensions[1]);

Replace with:

Code:

if ( $this->registry->options['attachthumbssize'] == $maxwidth AND $this->registry->options['attachthumbssize'] == $maxheight ) { // this is a thumbnail not a resize $vault_dimensions = explode(',', $this->registry->options['vaulti_thumb_width']); $maxwidth = intval($vault_dimensions[0]); $maxheight = intval($vault_dimensions[1]); }
Reply
August 10, 2009 9:26 AM

vimto

Regular Member

Many thanks,

Working like a dream now.

Reply

+ Reply

All times are GMT -4. The time now is 5:17 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Problems uploading images

Issue Tools