Issue: Wiki url manager false positive

Issue Tools
- View Changes

July 28, 2009 1:47 AM

tommythejoat

Regular Member

Wiki url manager false positive

The wiki url manager gives false positives on extended names

This may be working correctly, but is at least confusing. There are two distinct articles: Waltham Watch Co. and American Waltham Watch Co.

When I click on the edit button it tells me they do not conflict, yet they are listed.

Issue Details

Issue Number 730

Issue Type Bug

Project VaultWiki 3.x Series

Category Admin Panel

Status Fixed

Priority 7 - Minor Features / Enhancements

Affected Version 2.5.0

Fixed Version 2.5.0

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

July 28, 2009 2:26 AM

pegasus

VaultWiki Team

Interesting. Try this - in admincp/vaultwiki_url.php, find:

Code:

			AND title_enc = '" . $db->escape_string($vbulletin->GPC['title']) . "'

Replace with:

Code:

			AND title_enc = '" . $db->escape_string(strtolower($vbulletin->GPC['title'])) . "'

July 28, 2009 4:18 PM

pegasus

VaultWiki Team

In admincp/vaultwiki_namespace.php, find:

Code:

		if (!empty($list))
		{

Add after:

Code:

			if ($vbulletin->GPC['startat'] == 0)
			{
				$db->query_write("
					DELETE FROM " . TABLE_PREFIX . "vault_list
					WHERE namespaceid IN (" . implode(',', $dataman->rebuild['namespace']) . ")
				");
			}

In admincp/vaultwiki_url.php, find:

Code:

	if (!empty($list))
	{

Add after:

Code:

		if ($vbulletin->GPC['startat'] == 0)
		{
			$db->query_write("TRUNCATE TABLE " . TABLE_PREFIX . "vault_list");
		}

Save. Rebuild All Namespaces.

July 29, 2009 10:11 AM

tommythejoat

Regular Member

If the above patches made it into the version I downloaded this morning (and copied to my board), the problem is not fixed.

This is the duplicate name list now. The article that I bombed with yesterday has been added to the list.

/showwiki.php?title=Book:Encyclopedia+Writers+Guide 2 Edit
/showwiki.php?title=American+Waltham+Watch+Co 2 Edit
/showwiki.php?title=Waltham+Watch+Co 2 Edit

Reply
August 24, 2009 10:16 AM
tommythejoat

Regular Member
I just installed 2.5.1 and hoped that this would be gone, but it is not.

The current list reads:

/showwiki.php?title=Header:Wiki+Header-34
/showwiki.php?title=American+Waltham+Watch+Co
/showwiki.php?title=Appleton+Tracy+and+Co

If I click on edit for any of these I get the message that there is no conflict.
Reply

August 24, 2009 12:45 PM

pegasus

VaultWiki Team

In admincp/vaultwiki_url.php, find:

Code:

	$dupes = $db->query_read("

Add before:

Code:

	if ($vbulletin->options['vault_spaces'] == 0)
	{
		$vbulletin->GPC['title'] = str_replace(' ', '+', $vbulletin->GPC['title']);
	}

August 24, 2009 7:31 PM

tommythejoat

Regular Member

Are the names Appleton, Tracy and Co. and Appleton, Tracy & Co. identical now?

If a references is made to Appleton, Tracy & Co. in a forum post will it autolink to an article names Appleton, Tracy and Co.?

The feature is working now, but the net effect is not obvious. We have short reference type articles that are used to provide access to alias names. The above is an example of such a pair.

>>>>

Never mind, I just ran the experiment and they both will link.

Reply

+ Reply

All times are GMT -4. The time now is 9:39 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Wiki url manager false positive

Issue Tools