Issue: Alternate theme issue (image directory)

Issue Tools
- View Changes

July 22, 2009 3:39 PM

iMav

New Member

Alternate theme issue (image directory)

When using our default/primary theme, images are linked correctly in the wiki articles:

Code:

/*** links using the [URL] BB-Code, based on link protocol ***/
.link-http { background: url(http://geekhack.org/vault/images/external.png) center right no-repeat; }
.link-https { background: url(http://geekhack.org/vault/images/lock_icon.gif) center right no-repeat; }
.link-mailto { background: url(http://geekhack.org/vault/images/mail_icon.gif) center right no-repeat; }
.link-news { background: url(http://geekhack.org/vault/images/news_icon.png) center right no-repeat; }
.link-ftp { background: url(http://geekhack.org/vault/images/file_icon.gif) center right no-repeat; }
.link-irc { background: url(http://geekhack.org/vault/images/discussionitem_icon.gif) center right no-repeat; }

However, when using an alternate theme, I get this:

Code:

/*** links using the [URL] BB-Code, based on link protocol ***/
.link-http { background: url(http://geekhack.org//external.png) center right no-repeat; }
.link-https { background: url(http://geekhack.org//lock_icon.gif) center right no-repeat; }
.link-mailto { background: url(http://geekhack.org//mail_icon.gif) center right no-repeat; }
.link-news { background: url(http://geekhack.org//news_icon.png) center right no-repeat; }
.link-ftp { background: url(http://geekhack.org//file_icon.gif) center right no-repeat; }
.link-irc { background: url(http://geekhack.org//discussionitem_icon.gif) center right no-repeat; }

Even though "vault/images" is listed under StyleVars for both themes.

Issue Details

Issue Number 712

Issue Type Bug

Project VaultWiki 3.x Series

Category Wiki Pages

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 2.3.2

Fixed Version 2.5.0

Milestone VaultWiki 2.5.x

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

July 22, 2009 4:14 PM

pegasus

VaultWiki Team

Try editing the StyleVar, then reverting it. If I create a new theme (we created 8 recently), the stylevar is applied correctly.

My guess is that this is a bug from the 2.3.0 upgrader where the stylevar might not be present in memory right if it is the first upgrade (or fresh install) made since the stylevar was added.

I added some code to try to handle this for the next build, but users who already have a post-2.3.0 version will have to modify the stylevar themselves (or save the CSS again in the next build).

Reply
July 22, 2009 5:07 PM

iMav

New Member

modified it and then reverted it. no change.

Reply

July 22, 2009 5:15 PM

pegasus

VaultWiki Team

If that fails, try editing vault/special_adminfunctions_template.php. Find:

Code:

				$template_cache[$template['templatetype']][$template['title']] = $template;
			}
			$db->free_result($templates);

			foreach ($_query_css_templates AS $templatename)
			{

Replace with:

Code:

				$template_cache[$template['templatetype']][$template['title']] = $template;

				if ($template['templatetype'] == 'stylevar')
				{
					if (is_array($style['stylevars']))
					{
						$style['stylevars'][$template['title']] = $template['template'];
					}
					else if ($style['stylevars'] === null)
					{
						$style['stylevars'] = array($template['title'] => $template['template']);
					}
					else
					{
						$style['stylevars'] = unserialize($style['stylevars']);
						$style['stylevars'][$template['title']] = $template['template'];
					}
				}
			}
			$db->free_result($templates);

			if (is_array($style['stylevars']))
			{
				$style['stylevars'] = serialize($style['stylevars']);
			}

			foreach ($_query_css_templates AS $templatename)
			{

Then edit and save the Wiki CSS for the messed up style.

July 22, 2009 6:01 PM

iMav

New Member

no change. let me know what else you'd like to see and/or if you'd like access to see first hand.

Reply
July 22, 2009 7:33 PM

pegasus

VaultWiki Team

I made some changes to the replacement code. Please try again.

Reply
July 25, 2009 8:31 AM

iMav

New Member

Originally Posted by pegasus

I made some changes to the replacement code. Please try again.

No change.

Reply
July 25, 2009 1:09 PM

pegasus

VaultWiki Team

Can you PM me access to your Wiki Style Manager?

Thanks.

Reply

+ Reply

All times are GMT -4. The time now is 9:24 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Alternate theme issue (image directory)

Issue Tools