Issue: remove br from bbcode code box

Issue Tools
- View Changes

July 10, 2009 8:49 AM

gary.brain

Junior Member

remove br from bbcode code box

Hi, i noticed that the wiki addes the < br > to each line in a [ code ] where as it does not do this on a basic forum post.

Is it possible to remove this.

G.

Issue Details

Issue Number 672

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 2.3.2

Fixed Version 2.5.0

Milestone VaultWiki 2.5.x

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

July 10, 2009 11:10 AM

pegasus

VaultWiki Team

Wiki posts process new lines in a different order than basic forum posts do. I am not sure why the < br > tag would cause an issue. Is there a specific problem you are having?

Reply
July 11, 2009 5:54 AM
gary.brain

Junior Member
not realy, its just all the lines in a code box have an extra line between them making the post longer.

as the [ code ] is a <pre>code</pre> output there is no need for the extra line space.

e.h mine looks like this

Code:

test test test

but I noticed it does not happen on this forum.

What does your style code look like in the bbcode_code

yours looks like this.

Code:

test test test
Reply

July 11, 2009 12:54 PM

pegasus

VaultWiki Team

In vault/special_class_bbcode.php, find:

Code:

		$this->current_tag['name'] = 'code';

		eval('$html = "' . str_replace("\r\n", '', fetch_template($template)) . '";');

Replace with:

Code:

		$code = nl2br($code);
		$this->current_tag['name'] = 'code';

		eval('$html = "' . fetch_template($template) . '";');

		$html = preg_replace('#(\r|\n)#', '', $html);

Find:

Code:

		$code = str_replace(array("\r\n", "\r", "\n"), "<br />", $code);

		eval('$html = "' . str_replace("\r\n", '', fetch_template($template)) . '";');

Replace with:

Code:

		$code = nl2br($code);

		eval('$html = "' . fetch_template($template) . '";');

		$html = preg_replace('#(\r|\n)#', '', $html);

July 13, 2009 3:43 AM

gary.brain

Junior Member

works a treat, many thanks

G.

Reply

+ Reply

All times are GMT -4. The time now is 11:24 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: remove br from bbcode code box

Issue Tools