Issue: Quotes (") Not Always Parsed

Issue Tools
- View Changes

June 20, 2009 5:45 AM
Mokonzi

Senior Member
Quotes (") Not Always Parsed

Quotes (") Not Always Parsed when used along with a template in an article

I've had an article using the color BBCode:

HTML Code:

[COLOR="Lime"]Letter[/COLOR]

I've done this within a template, but the quotes " aren't being parsed, and instead are being replaced with "
When I edit them and remove the quote, it parses the BBCode properly, sometimes, while sometimes holding the old quotes in place.
This was an article created and unchanged since 2.3.0

Issue Details

Issue Number 637

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 6 - Dev-Related Tasks

Affected Version 2.3.1

Fixed Version 2.3.1

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

June 20, 2009 11:27 AM

pegasus

VaultWiki Team

Please link to the template where the problem is occurring.

Reply
June 20, 2009 6:21 PM

Mokonzi

Senior Member

http://www.thexuniverse.com/forum/sh...itle=Barracuda

That was the article that had the problem, but since editing it gone finally (after several attempts at editing).

I assume it was the upgrade process that caused it.

Reply
June 20, 2009 6:35 PM

Mokonzi

Senior Member

I'm also getting a formatting error in the editor... can't see why atm... can you have a look as well?

Thanks for the help matey.

Reply

June 20, 2009 8:53 PM

pegasus

VaultWiki Team

The following is causing problems:

HTML Code:

<a href="http://www.thexuniverse.com/forum/payments.php" class="mainmenu">&lt;img src="http://www.paypal.com/en_US/i/btn/x-click-but04.gif" style="opacity:0.8;filter:alpha(opacity=80)"
onmouseover="this.style.opacity=1;this.filters.alpha.opacity=100"
onmouseout="this.style.opacity=0.8;this.filters.alpha.opacity=80"
border="0" alt="Please help us to develop!" hspace="3" /></a>

It attempts to access "this.filters" which I believe is only available is some versions of IE. Accessing a null object like this causes Javascript to crash in other browsers.

June 21, 2009 2:58 AM

Mokonzi

Senior Member

Odd. How come I only get it in the wiki section of the site?

Reply
June 21, 2009 6:52 PM

pegasus

VaultWiki Team

In showwiki.php, find:

PHP Code:

$xml->add_tag('url', $threadinfo['url'] . $vbulletin->session->vars['vw_sessionurl_d'] . "do={1:tabid}");

Replace with:

PHP Code:

$xml->add_tag('url', $threadinfo['url'] . $vbulletin->session->vars['vw_sessionurl_js'] . "do={1:tabid}");

Reply
June 22, 2009 2:39 AM

Mokonzi

Senior Member

Fixed it like a dream

Reply
June 22, 2009 3:20 AM

pegasus

VaultWiki Team

Great. According to what I've seen in other boards with this problem, this should also have fixed the bug you originally reported in the first post.

Marked as fixed.

Reply
June 22, 2009 9:45 AM

Mokonzi

Senior Member

Thanks pegasus

Reply
June 24, 2009 5:03 PM

Mokonzi

Senior Member

Still getting the error in the first post, but only when I use quotes in a template conditional, as soon as I remove the quotes, it parses the color BBCode correctly.

Reply
June 24, 2009 5:42 PM

pegasus

VaultWiki Team

Please post the entire template conditional.

Reply
June 25, 2009 3:49 AM

Mokonzi

Senior Member

I get it any template I try.
To clarify (as I'm not sure I've explained myself fully).
The BBCode isn't in the template, but is used in the article where I insert the template.
Anyways, one of the templates is:
[html][table] cellpadding="5" cellspacing="0" align="right" width="250"
|-
| style="padding-left: 5px; padding-top: 5px; padding-bottom: 5px; padding-right: 0px;" |

Ship Information
{{{Image}}}
Name {{{Ship}}}
Race {{{Race}}}
Class {{{ClassShort}}}, {{{ClassLong}}}
Predecessor {{{Predecessor}}}
Successor {{{Successor}}}
Variants {{{Variants}}}
[table] class="tborder" cellpadding="5" cellspacing="0" align="right" width="250"
|-
| class="alt3" style="font-size:10px" width="20%" | XbtF
| class="alt3" style="font-size:10px" width="20%" | X-T
| class="alt3" style="font-size:10px" width="20%" | [b]X

Reply

June 25, 2009 12:43 PM

pegasus

VaultWiki Team

In vault/special_class_template.php, find and remove:

Code:

[noparse]			$template_text = $this->process_template_params($template_cache[$threadids["$t"]]['pagetext'], $args);

			$template_text = $this->parser->parse_bbcode(
				$template_text,
				$this->parser->options['do_smilies'],
				$this->parser->options['do_html']
			);[/noparse]

Find:

PHP Code:


$threadinfo['templates'][$this->parser->recursion['template'] - 1]["$title"][intval($instance_no["$title"])] = array('args' => $args);

Add before:

Code:

[noparse]			$template_text = $this->process_template_params($template_cache[$threadids["$t"]]['pagetext'], $args);

			$template_text = $this->parser->parse_bbcode(
				$template_text,
				$this->parser->options['do_smilies'],
				$this->parser->options['do_html']
			);[/noparse]

June 26, 2009 11:22 AM

Mokonzi

Senior Member

Fixed perfectly as always...

PS there's a query/bug report in the Images section of the project I don't think you've seen...

Reply

+ Reply

All times are GMT -4. The time now is 11:20 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Ship Information
{{{Image}}}
Name	{{{Ship}}}
Race	{{{Race}}}
Class	{{{ClassShort}}}, {{{ClassLong}}}
Predecessor	{{{Predecessor}}}
Successor	{{{Successor}}}
Variants	{{{Variants}}}

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Quotes (") Not Always Parsed

Issue Tools