Issue: Special:WhatLinksHere doesn't work for autolinking tags

Issue Tools
- View Changes

October 10, 2022 4:34 AM

mazzly

Junior Member

Special:WhatLinksHere doesn't work for autolinking tags

If I use Special:WhatLinksHere it won't show pages linking to it unless they are wrapped in wiki-bbcode..

With wiki autolinking enabled, there are many more pages linking to it, and those should also be shown here..

Issue Details

Issue Number 6341

Issue Type Bug

Project VaultWiki 4.x Series

Category Special Pages

Status Flagged for Future

Priority 3 - Loss of Functionality

Affected Version 4.1.5

Fixed Version (none)

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 10, 2022 5:09 AM

pegasus

VaultWiki Team

This is by design. It is the WIKI BB-Code that logs the link to WhatLinksHere or similar Special pages. When no BB-Code is used, and the link is "found" at render time, there is no logging to take place. If we were to allow this, the autolink would disappear from WhatLinksHere almost immediately when the person who has autolinks disabled views the same content, as the link would suddenly show as removed from the content.

Reply
October 10, 2022 6:03 AM

mazzly

Junior Member

Wouldn't it be possible to check if the user checking the page has autolink enabled before fetching the pages?

Reply
October 10, 2022 6:10 PM

pegasus

VaultWiki Team

Yeah I considered that after posting, so it may work. The only real problem I see is that it would be a non-minor feature expansion, involve a number of database changes, and would need to be implemented in a way that is reliable -- where the capturing, maintaining, and updating of autolinks occurs consistently and in an expected manner. It's not something we could just drop into a minor release.

Reply
October 11, 2022 6:41 AM

mazzly

Junior Member

Yep sounds like it might need a bit more planning and maybe even collect those things on update/save as well as async with some job..

Reply
October 23, 2023 4:20 PM

pegasus

VaultWiki Team

Since this is the original thread for this:
- As of 4.1.7 (public release), autolinks will now show on Special:WhatLinksHere.
- There are some bugs involving rebuilds which should already be fixed in the next release.

However:
- Whenever a page is created, we need to perform a full-text search based on its title and expire the autolink/caches of any page that responds to the search
- We need to capture autolinks on-the-fly to account for newly created pages that suddenly linked

There would still be a cache delay for some cases, but at that point this should mostly make this work as expected.

Reply
October 24, 2023 9:02 AM

mazzly

Junior Member

Is there some way I can flush / force a rebuild of the auto link caches? I would really want to try that this works when it is rebuilt, as it doesn't seem to work on our wiki...

Reply
October 24, 2023 1:36 PM
pegasus

VaultWiki Team
In src/addons/vw/vw/_core/instance/parser/renderer/xf2.php, find:

Code:

$tags[$map['vw_autolink_tag']['tag']] = array(

AFTER it, add:

Code:

'wiki-link' => 1,

In src/addons/vw/vw/_core/model/parser/handle/autolink/vw.php, find:

Code:

$this->handler = vw_Hard_Core::fetch_object('Model', 'Parser/Handle', '', true);

Replace with:

Code:

$this->handler = $this->instance->model->callback_model();

In src/addons/vw/vw/_core/model/parser/handle/base/link/vw.php, find and remove:

Code:

unset($callback_list['vw_autolink_tag']);
Reply
October 25, 2023 4:05 AM

mazzly

Junior Member

Okay yeah that seems to make the link counts update when I save some page at least

Reply

+ Reply

All times are GMT -4. The time now is 2:16 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Special:WhatLinksHere doesn't work for autolinking tags

Issue Tools