Issue: Special:UnusedImages doesn't work

Issue Tools
- View Changes

October 10, 2022 4:28 AM

mazzly

Junior Member

Special:UnusedImages doesn't work

Images listed in Special:UnusedImages are both used in wiki attachment tags, as well as "main icon image" for pages.

Issue Details

Issue Number 6339

Issue Type Bug

Project VaultWiki 4.x Series

Category Images / Icons

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.5

Fixed Version 4.1.6

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 10, 2022 5:14 AM

pegasus

VaultWiki Team

I know for sure that the Special page doesn't consider main icon image, which perhaps we can change. As for wiki attachment tags not affecting it, I'll have to do some testing.

Reply
October 11, 2022 4:10 AM

pegasus

VaultWiki Team

From my investigation on this issue so far:
- vw_link.sortkey doesn't appear to properly store the prefix. This leads the actual image sortkey not to match the sortkey of the captured usage. This would cause a false UnusedImage when the actual image has a prefix.
- Usages where the BB-Code is added by a template may not be getting captured. I do not see an obvious reason why at this point.

Reply
October 11, 2022 6:56 AM
mazzly

Junior Member
Hmm the bb-code usage in template would also be useful, as we e.g. have infoboxes that are inserted with image:

Code:

[template]CharacterInfoBox |image=Image:spongebob-squarepants-portrait |name=Spongebob Squarepants |otherDetails=..... [/template]

But we usually also add the same infobox image as the "main icon image" for the page, so as long as that is captured I guess it would be fine
Reply

October 11, 2022 7:25 PM

pegasus

VaultWiki Team

Okay, so... the following appears to now be fixed in the next release, based on some preliminary testing. The following is from the changelog:

Code:

Fixed Bug: INJECT usage doesn't count as used link [since: 4.1.0 Alpha 1] [lite: no]
Fixed Bug: [note#34994] links nested in templates don't count as used [lite: no]
Fixed Bug: attachments in GALLERY don't count as used [lite: no]
Fixed Bug: links in uninherited custom field values don't count as used [in: XF >= 2.0] [since: 4.1.0 RC 1] [lite: no]
Fixed Bug: [i#6339] icon image attachments don't count as used [since: 4.0.1] [lite: no]
Fixed Bug: [i#6339] prefix missing from link sortkey leading to Special:Unused* false positives [lite: no]

This petition for a change to Confirmed was accepted
October 21, 2023 11:02 AM

mazzly

Junior Member

As discussed in https://www.vaultwiki.org/issues/6389/ this feature still doesn't seem to work...

October 22, 2023 2:23 PM

pegasus

VaultWiki Team

Fixed in the next release. A lot of links were improperly tracked:

Code:

Fixed Bug: [i#6339] incorrect prefix in link sortkey leading to Special:Unused* false positives [since: 4.1.7] [lite: no]
Fixed Bug: existing links become untracked when saving a page w/ no changes [since: 4.1.6] [lite: no]

This results in, after upgrading, all pages having no links/images recorded until they are edited again. After editing, the link keys don't match the keys on the target page, so the target page doesn't know it has received a link.

In src/addons/vw/vw/_core/controller/dm/page/vw.php, find:

Code:

		if (!$this->instance->get_info('skip_links'))
		{
			$this->process_links();
		}

		if (
			// or if we even need a new revision at all
			$this->warrants_revision($lastrevision)
		)

Replace with:

Code:

		$warranted = $this->warrants_revision($lastrevision);
		$this->instance->set_info('is_revision_warranted', $warranted);

		if (!$this->instance->get_info('skip_links'))
		{
			$this->process_links();
		}

		if ($warranted)

Find:

Code:

			if (!$this->linkdm OR !$this->is_edit_current())
			{
				if ($this->instance->get_info('clear_links'))
				{
					$link = array(
						'contenttypeid' => vw_Hard_Core::model('ContentType')->one('vw_Page'),
						'contentid' => $this->instance->get('pageid')
					);

					$dm = vw_Hard_Core::controller('DM')->create('Link', 'SILENT');
					$dm->set_info('is_automated', 1);
					$dm->set_existing($link);
					$dm->instance->controller->set_batch_condition();
					$dm->delete();
					unset($dm);
				}
				return;
			}

Replace with:

Code:

			if (!$this->linkdm AND $this->instance->get_info('clear_links'))
			{
				$link = array(
					'contenttypeid' => vw_Hard_Core::model('ContentType')->one('vw_Page'),
					'contentid' => $this->instance->get('pageid')
				);

				$dm = vw_Hard_Core::controller('DM')->create('Link', 'SILENT');
				$dm->set_info('is_automated', 1);
				$dm->set_existing($link);
				$dm->instance->controller->set_batch_condition();
				$dm->delete();
				unset($dm);
			}

			if (!$this->linkdm OR !$this->is_edit_current())
			{
				return;
			}

Find:

Code:

		else if (!$this->instance->get_existing('revisionid'))
		{
			return true;
		}

AFTER it, add:

Code:

		$warranted = $this->instance->get_info('is_revision_warranted');

		if ($warranted === false)
		{
			return true;
		}

In src/addons/vw/vw/_core/controller/dm/batch/vw.php, find:

Code:

$dm->setr($field, $value);

Replace with:

Code:

$dm->set($field, $value);

October 22, 2023 3:03 PM

mazzly

Junior Member

That seems to have done the trick, after rebuilding now it shows a more sane list of images

Reply

+ Reply

All times are GMT -4. The time now is 6:43 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Special:UnusedImages doesn't work

Issue Tools