Issue: Image attachments should default Main icon image to show the image

Issue Tools
- View Changes

September 20, 2022 2:39 AM

mazzly

Junior Member

Image attachments should default Main icon image to show the image

If we create an image attachment, the Main icon image should default to showing the same image instead of an "image icon"

At minimum this should be an option that can be enabled

Issue Details

Issue Number 6334

Issue Type Bug

Project VaultWiki 4.x Series

Category Images / Icons

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.5

Fixed Version 4.1.6

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 20, 2022 11:19 AM

pegasus

VaultWiki Team

When I see an attachment in a content list, or even in that attachment's icon editor field, the icon it shows is actually the image that was uploaded as the attachment.

I'm guessing that you mean the icon next to the title on the attachment's "page" view. I see that the code there specifically strips out the "custom" CSS class from this one instance, possibly because it results in the same image appearing twice in this view (once next to the title + once in the body). However, this does not appear to be documented in the original tech outline of the icon feature, nor in any follow-up posts, so I am inclined to treat this as a consistency bug and add an admin option, where the default value is actually the behavior you want.

Reply
September 21, 2022 8:44 AM

mazzly

Junior Member

In the Wiki area under "Pages in X" it shows with just the thumbnail icon, not the image (it has class vw-icon-attach-2089, so I'm guessing that is something some JS would use to lazyload it?)

Reply
September 21, 2022 2:54 PM
pegasus

VaultWiki Team
Okay, this looks like a bug that occurs when you have disabled allowing custom-URLs as the icon:

Since attachment icons are basically just a wrapper for the attachment's URL, this causes a problem for the case of attachment icons using themselves, which is a code path that did not have a mechanism bypass the custom-URL toggle. Since attachment icons using themselves is basically still an attachment choice and not a custom-URL choice, it should bypass the setting in that case. However, if attachment choices are disabled, then the attachment should not use itself as an icon, and it currently does.

In src/addons/vw/vw/_core/view/factory/icon/vw.php, find:

Code:

if (!($icon_options & $icon_bits['url']))

Replace with:

Code:

$bit = 'url'; if (isset($info['icon'][2])) { $bit = 'attach'; } if (!($icon_options & $icon_bits[$bit]))
Reply

+ Reply

All times are GMT -4. The time now is 4:43 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Image attachments should default Main icon image to show the image

Issue Tools