Issue: Creating new wiki attachment while editing page doesn't work (modal)

Issue Tools
- View Changes

September 17, 2022 3:24 AM

mazzly

Junior Member

Creating new wiki attachment while editing page doesn't work (modal)

When I edit a page and want to e.g. add an image to the page I click the "wiki attachment" icon which opens the "File browser"

There I click "New attachment", which (probably minor) logs the following to dev console:

Code:

empty.gif:1          GET [url]https://www......com/empty.gif[/url] 404

Then I upload the image and fill in the details, when I click "Create now", the following happens in console:

Code:

icon-switch.js?v=4e5d8ee5:7 Uncaught TypeError: Cannot read properties of undefined (reading 'onsubmit_complete')
    at Object.onsubmit_complete (icon-switch.js?v=4e5d8ee5:7:16999)
    at Object.<anonymous> (icon-switch.js?v=4e5d8ee5:7:16350)
    at e.Subscriber._notify (combo-min.js:4:51)
    at e.Subscriber.notify (combo-min.js:4:245)
    at e.CustomEvent._notify (combo-min.js:3:4257)
    at e.CustomEvent._procSubs (combo-min.js:3:4916)
    at e.CustomEvent.fireSimple (combo-min.js:3:4655)
    at e.CustomEvent._fire (combo-min.js:3:4539)
    at o.fire (combo-min.js:4:5467)
    at o._evt (wiki_js.php?v=3.18.1&f=querystring-stringify-simple/querystring-stringify-simple-min.js,io-base/io-base-min.js:3:1605)

From what I can tell from "recent changes", nothing is actually uploaded/created

Issue Details

Issue Number 6326

Issue Type Bug

Project VaultWiki 4.x Series

Category Attachments

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.5

Fixed Version 4.1.6

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 17, 2022 3:10 PM
pegasus

VaultWiki Team
For clarification, this occurs only when using the editor field:
- Main Icon Image > Enter the name of a wiki attachment > File Browser button > New attachment

When using the File Browser button in the editor BB-Code toolbar, this does not occur.

Fixed in the next release. This occurs because the name of one Javascript variable gets overwritten with a new one when the old information will still be needed later.

If using unminified Javascript, in js/vw/vw/icon-switch.js, find:

Code:

config.arguments = {

AFTER it, add:

Code:

creator: creator,

If using minified Javascript, in js/vw/vw/xf2/compiled/icon-switch.js, find:

Code:

c.arguments={context:this}

Replace with:

Code:

c.arguments={creator:d,context:this}

This change resolved the issue on my wiki. You may have to refresh the browser with cache disabled and possibly expire the file in any server-side static file cache such as CDN or CloudFlare in order to notice a difference.
Reply

+ Reply

All times are GMT -4. The time now is 10:02 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Creating new wiki attachment while editing page doesn't work (modal)

Issue Tools