Issue: Converting a Book page into page removes/breaks it

Issue Tools
- View Changes

September 16, 2022 2:40 AM

mazzly

Junior Member

Converting a Book page into page removes/breaks it

Someone had wrongly created a page as a "Book"

When we edited it and unchecked the "Treat this page as a: Book" it dissapeared after saving..

It should probably either:
- Be prevented (I guess if chapters etc??)
- Be converted to normal page..

Issue Details

Issue Number 6320

Issue Type Bug

Project VaultWiki 4.x Series

Category Books / Chapters

Status Fixed

Priority 1 - Security / Login / Data Loss

Affected Version 4.1.5

Fixed Version 4.1.5

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 16, 2022 1:00 PM
pegasus

VaultWiki Team
Thank you for reporting this potentially devastating issue. It seems that a bug fix for an unrelated issue in early 2021 (https://www.vaultwiki.org/issues/6152/, which I'm not sure even fixed that problem) introduced this.

When removing a book/category behavior from a page using the page's editor, a flag is supposed to be set so that only the behavior gets deleted and not the entire page. However, that "fix" I mentioned earlier added a "reset" into the delete chain which has the consequence of removing all the flags. So the delete process then sees that the "don't-delete-the-page" flag is not set and deletes the page too when removing the behavior.

In src/addons/vw/vw/XF/Entity/EntityBase.php, find and remove:

Code:

$this->reset();

Find (earlier):

Code:

if (!$this->exists() AND !$this->vwCondition)

BEFORE it, add:

Code:

$info = $this->vwInfo; $this->reset(); $this->vwInfo = $info;

This change should preserve any flags through the reset.

This issue is fixed in the next release and will also be included in next months patches, as it involves unintentional data loss.
Reply

+ Reply

All times are GMT -4. The time now is 4:37 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Converting a Book page into page removes/breaks it

Issue Tools