Issue: [4.1.4] Job: UserAction.php add_had_group missing third argument (state)

Issue Tools
- View Changes

April 14, 2022 7:16 AM

ACL

Regular Member

[4.1.4] Job: UserAction.php add_had_group missing third argument (state)

ArgumentCountError: Too few arguments to function vw_User_Model::add_had_group(), 2 passed in /home/auschr1/xenforo_devtest/XF22/src/addons/vw/vw/XF/Job/UserAction.php on line 36 and exactly 3 expected in src/addons/vw/vw/_core/model/user/vw.php at line 260

Function applyExternalUserChange calls add_had_group with only two arguments ($this->data['actions']['add_group_id'], $vwuser);. This add_had_group function in vw_User_model is structured as add_had_group($groupid, $user, $state). A queued XF:UserAction job is pending.

Code:

vw_User_Model->add_had_group() in src/addons/vw/vw/XF/Job/UserAction.php at line 36
vw\vw\XF\Job\UserAction->applyExternalUserChange() in src/XF/Job/UserAction.php at line 32
XF\Job\UserAction->executeAction() in src/XF/Job/AbstractUserCriteriaJob.php at line 61
XF\Job\AbstractUserCriteriaJob->run() in src/XF/Job/Manager.php at line 260
XF\Job\Manager->runJobInternal() in src/XF/Job/Manager.php at line 202
XF\Job\Manager->runJobEntry() in src/XF/Job/Manager.php at line 86
XF\Job\Manager->runQueue() in src/XF/Admin/Controller/Tools.php at line 141
XF\Admin\Controller\Tools->actionRunJob() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 259
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2352
XF\App->run() in src/XF.php at line 524
XF::runApp() in admin.php at line 13

Issue Details

Issue Number 6301

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.4

Fixed Version 4.1.5

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 14, 2022 11:03 AM

pegasus

VaultWiki Team

Judging by the context that queues this job, it looks like the $state should be set to 0.

In src/addons/vw/vw/XF/Job/UserAction.php, find:

Code:

$hadGroup = \vw_Hard_Core::model('User')->add_had_group($this->data['actions']['add_group_id'], $vwuser);

Replace with:

Code:

$hadGroup = \vw_Hard_Core::model('User')->add_had_group($this->data['actions']['add_group_id'], $vwuser, 0);

+ Reply

All times are GMT -4. The time now is 2:38 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1.4] Job: UserAction.php add_had_group missing third argument (state)

Issue Tools