Issue: Now I've commented on an article I cannot edit it or post again

Issue Tools
- View Changes

April 28, 2020 4:15 AM

expanserpb

Junior Member

Now I've commented on an article I cannot edit it or post again

No errors in error log?

Issue Details

Issue Number 6025

Issue Type Bug

Project VaultWiki 4.x Series

Category Unknown

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 RC 1

Fixed Version 4.1.0 RC 3

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 28, 2020 1:22 PM

pegasus

VaultWiki Team

This is fixed in the next release. On some platforms, it is also not possible to make a first comment due to the invalid URL. The problem is related to the changes to comments from RC 1.

In src/addons/vw/vw/_core/model/url/discussion/vw.php, find:

Code:

		if (!empty($urlinfo['pageid']))
		{
			$parent = vw_Hard_Core::controller('Fetch')->get('Page', $urlinfo['pageid']);

Replace with:

Code:

		$contenttypeid = 0;
		$contentid = 0;

		if (!empty($urlinfo['contentid']))
		{
			$contentid = $urlinfo['contentid'];
			$contenttypeid = $urlinfo['contenttypeid'];
		}
		else if (!empty($urlinfo['pageid']))
		{
			$contentid = $urlinfo['pageid'];
			$contenttypeid = vw_Hard_Core::model('Node')->id('Page');
		}

		if ($contentid)
		{
			$parent = vw_Hard_Core::controller('Fetch')->get($contenttypeid, $contentid);

April 28, 2020 2:12 PM

expanserpb

Junior Member

Same error

Reply

April 28, 2020 2:13 PM

expanserpb expanserpb is offline

Junior Member

Code:

class vw_URL_Discussion_Model
{
	public function get(&$urlinfo)
	{
		$contenttypeid = 0;
		$contentid = 0;

		if (!empty($urlinfo['contentid']))
		{
			$contentid = $urlinfo['contentid'];
			$contenttypeid = $urlinfo['contenttypeid'];
		}
		else if (!empty($urlinfo['pageid']))
		{
			$contentid = $urlinfo['pageid'];
			$contenttypeid = vw_Hard_Core::model('Node')->id('Page');
		}

		if ($contentid)
		{
			$parent = vw_Hard_Core::controller('Fetch')->get($contenttypeid, $contentid);


			vw_Hard_Core::model('URL')->get($parent);

April 28, 2020 2:59 PM

pegasus

VaultWiki Team

Your site is working for me: quick-edit on existing comments now loads the editor, and quick-replies submit to the correct URL, after you made the file edit. If you are still experiencing the "same error", you need to describe the original issue in more detail (only a screenshot was posted), because apparently it is different from what I understood from the image.

Reply
April 28, 2020 3:26 PM

expanserpb

Junior Member

I do apologise. Either I'd missed WinSCP not uploading the new file or something was cashed!

Reply

+ Reply

All times are GMT -4. The time now is 8:41 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Now I've commented on an article I cannot edit it or post again

Issue Tools