Issue: [4.1 Beta 4] VaultWiki table BB code tag (if modified) seems to be reset to the default 'table1' value during upgrade

Issue Tools
- View Changes

October 17, 2019 11:51 AM

ACL

Regular Member

[4.1 Beta 4] VaultWiki table BB code tag (if modified) seems to be reset to the default 'table1' value during upgrade

I'm currently running a couple of testing instances of VW4.1 Beta 4 b002 (XF2.1 version). Both instances were recently upgraded from Beta 3 (b003, b002). Sometime during the upgrade, the previously customised bb code tag wtable was reset to table1. Is this step skippable?

Over the past week or so, I've gone through my public site's wiki (XF1.5) and changed any existing references to the 'table' bbcode tag to 'wtable' to avoid a conflict with the new XF2.1 table bbcode. I'd like to keep this bb code tag set to the value 'wtable', if possible. To me, wtable is more meaningful than table1.

I also plan to apply the same edit to the gallery1 bbcode tag, i.e. gallery1 -> wgallery. However, I didn't make this change before the upgrade so I can't comment on whether this VW gallery bbcode tag gets reset during upgrades.

Issue Details

Issue Number 5898

Issue Type Bug

Project VaultWiki 4.x Series

Category Install / Upgrade

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 Beta 4

Fixed Version 4.1.0 Beta 4

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 17, 2019 12:14 PM

pegasus

VaultWiki Team

Fixed in the next build. This occurs when the default tag name conflicts with a non-wiki BB-Code and the wiki BB-Code has already been renamed. In this case, instead of using the existing renamed tag it creates a new one.

We fix this by checking for an existing tag earlier rather than waiting until we've found a conflict.

Reply
October 21, 2019 12:33 PM
ACL

Regular Member
Thanks for looking at this.

I've run into a different custom bbcode issue when upgrading to the XF2.1 branch of VW 4.1 Beta 4 b002 from XF1.5. Wiki bbcodes where the bbcode tag has been customized are missing after the upgrade. Other wiki bbcodes that were not previously customized have been retained. In my case, I previously changed the bb code tag of table1 (to wtable) and gallery1 ( to wgallery) and both are missing in XF2.1.

Would your fix also apply to this scenario or is a different fix required?

I attempted to recreate the wtable bbcode but this triggered an invalid argument exception (with vw_varname = vw_table_tag):
InvalidArgumentException: Attempted to convert array to string/binary [vw_extra] in src/XF/Mvc/Entity/Entity.php at line 740

Code:

XF\Mvc\Entity\Entity->_castValueToType() in src/XF/Mvc/Entity/Entity.php at line 618 XF\Mvc\Entity\Entity->set() in src/XF/Mvc/Entity/Entity.php at line 720 XF\Mvc\Entity\Entity->bulkSet() in src/addons/vw/vw/XF/Admin/Controller/BbCode.php at line 81 vw\vw\XF\Admin\Controller\BbCode->bbCodeSaveProcess() in src/XF/Admin/Controller/BbCode.php at line 126 XF\Admin\Controller\BbCode->actionSave() in src/XF/Mvc/Dispatcher.php at line 321 XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248 XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100 XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50 XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2178 XF\App->run() in src/XF.php at line 390 XF::runApp() in admin.php at line 13
Reply
October 22, 2019 8:20 AM
pegasus

VaultWiki Team
The fix I discussed also applies to this scenario.

For the exception, in src/addons/vw/vw/XF/Admin/Controller/BbCode.php, find:

Code:

if (!empty($extra))

Replace with:

Code:

if (is_array($extra))
Reply

+ Reply

All times are GMT -4. The time now is 12:45 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 4] VaultWiki table BB code tag (if modified) seems to be reset to the default 'table1' value during upgrade

Issue Tools