Issue: [4.1 Beta 3] Mass-management tools: Criteria selection undefined variable: last_order, when areachoice is [Select All Areas](0)

Issue Tools
- View Changes

October 1, 2019 10:43 AM

ACL

Regular Member

[4.1 Beta 3] Mass-management tools: Criteria selection undefined variable: last_order, when areachoice is [Select All Areas](0)

In XF2.1, attempting to progress from the 'Criteria Selection' to the 'Prepare and Review' stage is interrupted by an undefined variable error when the area selection form element areachoice[] is set to "[Search All Areas]" (value="0"). When a specific area is selected, this undefined variable error is not triggered.

ErrorException: [E_NOTICE] Undefined variable: last_order src/addons/vw/vw/_core/view/cp/massive/vw.php:296

Code:

#0 src/addons/vw/vw/_core/view/cp/massive/vw.php(296): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/volume1/web/xf...', 296, Array)
#1 src/addons/vw/vw/_core/view/cp/massive/vw.php(239): vw_CP_Massive_View->get_results_nav(Object(vw_CP_Massive_Controller), Array, Array)
#2 src/addons/vw/vw/_core/view/reply/view/vw.php(48): vw_CP_Massive_View->results(Array)
#3 src/addons/vw/vw/_core/view/reply/base/vw.php(134): vw_Reply_View_View->render_type('json')
#4 src/addons/vw/vw/XF/Mvc/View.php(87): vw_Reply_base_View->render('json')
#5 src/XF/Mvc/Renderer/AbstractRenderer.php(91): vw\vw\XF\Mvc\View->renderJson()
#6 src/XF/Mvc/Renderer/Json.php(63): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('vw\\vw:Wiki', 'admin:vw_genera...', Array)
#7 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Json->renderView('vw\\vw:Wiki', 'admin:vw_genera...', Array)
#8 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#11 src/XF/App.php(2178): XF\Mvc\Dispatcher->run()
#12 src/XF.php(390): XF\App->run()
#13 admin.php(13): XF::runApp('XF\\Admin\\App')
#14 {main}

Issue Details

Issue Number 5886

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.1.0 Beta 3

Fixed Version (none)

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 1, 2019 12:03 PM
pegasus

VaultWiki Team
This issue occurs whenever the criteria return more than 1 page of results. It leads to the next-page links only showing 1 additional result.

In src/addons/vw/vw/_core/view/cp/massive/vw.php, find:

Code:

intval($last_order[2] + 1)

Replace with:

Code:

intval($last[2] + 1)
Reply

+ Reply

All times are GMT -4. The time now is 5:25 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 3] Mass-management tools: Criteria selection undefined variable: last_order, when areachoice is [Select All Areas](0)

Issue Tools