• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 4.x Series
    • Bug
    • [4.1 Alpha 2] Several issues on comments page: Template error, Empty more options (...) menu, Problems interacting with comments

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: [4.1 Alpha 2] Several issues on comments page: Template error, Empty more options (...) menu, Problems interacting with comments

    • Issue Tools
      • View Changes
    1. issueid=5672 March 12, 2019 10:22 AM
      ACL ACL is offline
      Regular Member
      [4.1 Alpha 2] Several issues on comments page: Template error, Empty more options (...) menu, Problems interacting with comments

      Seen on the VW XenForo demo here:
      Code:
      https://www.vaultwiki.org/xf-wiki/index.php?wiki/=&title=ito3a-title-gif-Test&do=comments
      1) Template public:message_macros: Cannot call method isAttachmentEmbedded on a non-object (array) (src/XF/Template/Templater.php:963)

      2) The "..." (more options) menu next to "watch this discussion" doesn't have any options in the menu. If the lack of any options is correct, the template handling the menu should have a contentcheck on the menu items, to determine whether the menu button needs to be rendered in the first place.

      3) Underneath the first tab header with "Page", "Comments", "View" etc is a second tab block with just "Comments". Is this supposed to be there? If no, then the parent elements block-tabHeader and block-container could be removed, too.

      4) Errors are recorded to the console when attempting to interact with an existing comment in a number of ways.
      • Reply to the comment with a quote:
        Code:
        * Errors were triggered when rendering this template:
              Template public:message_macros: Cannot call method isAttachmentEmbedded on a non-object (array) (src/XF/Template/Templater.php:963)  core.js:1886:5
        * TypeError: e is undefined
      • Add comment to multiquote (fails when inserting quotes into reply editor):
        Code:
        ErrorException: [E_NOTICE] Undefined variable: _quoteids in /home/vw/edge/upload/vault/core/controller/ui/discussion/xf2.php at line 120


      5) Certain links for existing comments are broken
      • Permalink (comment number e.g. #1, timestamp): https://www.vaultwiki.org/xf/index.php?members/
      • Users who liked comment (likesBar): https://www.vaultwiki.org/xf-wiki/in...st&do=comments
    Issue Details
    Issue Number 5672
    Issue Type Bug
    Project VaultWiki 4.x Series
    Category Discussions / Comments
    Status Fixed
    Priority 4 - Warnings / Script Errors
    Affected Version 4.1.0 Alpha 2
    Fixed Version (none)
    Milestone (none)
    Software DependencyXenForo 2.x
    License TypePaid
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. March 13, 2019 4:37 PM
      pegasus pegasus is offline
      VaultWiki Team
      Fixed 1,2,4, and 5 in Alpha 3.

      #3 is intentional as there might be multiple headings on this tab, with comments not actually being at the top. The heading actually displays the name of the discussion (the default name being "Comments"). It might be worth hiding the heading if it is using the default text which matches the tab text, if there are no other headings above it, and if it is not displayed inline below the page content; it depends how easy it is to achieve this whether we would invest the time to do it now.
      Reply Reply  
    2. September 23, 2019 9:18 AM
      pegasus pegasus is offline
      VaultWiki Team
      Tweaked #3 in the next release for XenForo 2. This was not tweaked in other forum platforms because the discussion controls appear inside the heading on those platforms.
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 4:43 AM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2025 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2025 DragonByte Technologies Ltd.
    Copyright © 2008 - 2024 VaultWiki Team, Cracked Egg Studios, LLC.