Issue: Page Anchors no longer work

Issue Tools
- View Changes

February 7, 2019 5:53 AM

Alfa1

Distinguished Member

Page Anchors no longer work

After upgrade from 4.0.24 to 4.0.25 PL1 page anchors no longer work.

Synonyms to page sections no longer link to the section. Instead links go to the top of the page.

Issue Details

Issue Number 5625

Issue Type Bug

Project VaultWiki 4.x Series

Category Synonyms

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.25

Fixed Version 4.1.0 Beta 1

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

February 12, 2019 1:33 PM

pegasus

VaultWiki Team

Does the synonym link include the appropriate #hash? Clicking the link forwards to the correct URL with the #hash, but the page does not jump to the heading?

Or does the link not even include a #hash?

Reply
February 12, 2019 2:39 PM

Alfa1

Distinguished Member

Please go to my site and use the synonym 'add item'
This should link you to the 'adding an item' section of the 'reviews' article.

Reply
February 12, 2019 4:02 PM

pegasus

VaultWiki Team

Okay the link includes the expected #hash and the browser moves to the #hash URL, but it doesn't jump to the heading after it loads.

Confirmed, caused by the following:

After the patch for VWE-2017-3734, the section-synonym hashes were not updated by the same patch, so affected synonyms have been pointing to the top of the page since then. This has been broken since May 7, 2017, whenever you applied a relevant patch, or upgraded to version 4.0.18 or higher.

Reply
February 13, 2019 6:01 PM
pegasus

VaultWiki Team
While the patch I referenced in my previous post was an underlying factor, it was not the ultimate cause of the issue. In the end, it was caused by the fix for:

Code:

Fixed Bug: same-page section links don't jump on click

Since the May 2017 patch, only the section link in the browser address bar would work. If a link was on the current page that linked to a section on the current page, clicking that link was not working.

The fix for that issue shipped in 4.0.21 and introduced a timing bug, where the section link in the browser address bar would no longer jump to the correct section if the browser onload event had already been triggered before the Javascript which queued the jump to the onload event.

This is now fixed in the next release of 4.0.x and the next build of 4.1.x.

If you are using the unminified Javascript, in vault/resources/js/section.js, find:

Code:

Y.on("load", function(e) { fn(true); });

Replace with:

Code:

if (document.readyState == "complete") { fn(true); } else { Y.on("load", function(e) { fn(true); }); }
Reply

+ Reply

All times are GMT -4. The time now is 11:33 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Page Anchors no longer work

Issue Tools