Issue: [4.1 Alpha 1] Admin Options: "VaultWiki: Content Types" step=5 and min=1 does not permit default values, e.g. 125 must be 121 or 126.

Issue Tools
- View Changes

January 2, 2019 7:01 AM
ACL

Regular Member
[4.1 Alpha 1] Admin Options: "VaultWiki: Content Types" step=5 and min=1 does not permit default values, e.g. 125 must be 121 or 126.

In XF2.0 addon settings (VaultWiki: Content Types section), there is an issue with the default value, minimum value and step amount for a few fields. This applies to vw_page_title_max, vw_talk_title_max.
Format parameters:

Code:

min=1 step=5 max=255

Default value:
125.

XenForo will not allow a 125 value when saving. It suggests changing to 121 or 126. This problem can be fixed if you change the min parameter to 5

Code:

min=5 step=5 max=255

The same issue occurs for other options as well, just with different format parameter and default values.

vw_attach_usage
vw_perpage_comment
vw_perpage_talk
vw_perpage_hist
vw_perpage_special
vw_perpage_area
vw_perpage_book
vw_perpage_category
vw_perpage_feed

Issue Details

Issue Number 5562

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.1.0 Alpha 1 Public

Fixed Version 4.1.0 Alpha 1 Public

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

January 2, 2019 5:39 PM

pegasus

VaultWiki Team

This seems like a bug in XenForo 2, since the value is only enforced by the browser. The value is not enforced in \XF\Entity\Option, and this behavior is inconsistent with XenForo 1.x. The "step" was always used as a convenience for users to increment/decrement values quickly, not limit the user.

I have forwarded this to the XenForo devs and we will see whether they confirm it is a bug or say that the change in behavior is intentional.
https://xenforo.com/community/thread...havior.158697/

Reply
January 2, 2019 7:42 PM

pegasus

VaultWiki Team

Update: the bug will be fixed in XenForo 2.1.0 Beta 6. Based on their instructions, I have made the necessary changes to the option XML to workaround the issue and support the XF2 fix when it is published. Not sure why they labelled it Not a Bug.

The updated XML will appear in build 003. After applying build 003, using XF2's add-on Rebuild should resolve the issue.

Reply

+ Reply

All times are GMT -4. The time now is 2:30 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Alpha 1] Admin Options: "VaultWiki: Content Types" step=5 and min=1 does not permit default values, e.g. 125 must be 121 or 126.

Issue Tools