Issue: 2.0 Bugs found

Issue Tools
- View Changes

June 26, 2008 3:26 PM
vimto

Regular Member
2.0 Bugs found

Editing Headers in forums:
I've tested this in the Default vBulletin style.

Upon loading a forum I see the "Add content to this header by editing it" link. After clicking on this link a tab loads that has the options "article" and "edit", the content shows Header:header-13, If I click on edit it will load up the edit page and allow me to enter content.

If I enter text into the Title and the content box it will come up with this error:

Code:

Fatal error: Call to a member function save() on a non-object in /home/mywebsite/public_html/forums/vault/tabs/special_tab_edit.php on line 793

If i leave the title as it is and just enter the content it will allow me to save the page and I can see the changes I have made....however, when I return to the forum where I edited this header the changes have not been made, nor are they showing in the header forum which remains empty.

- - - - - - - -

I next went to the header forum and created a new post with the title Header-13 and added some content. When I returned to the forum it showed the new content in the header.
I then clicked on the edit header link and the page just reloads to my default folder and not to the edit page.

It appears that the header I create is being saved to my wiki forum and not the header forum. I checked in the CES VaultWiki options and it has the correct forum listed in the Headers Namespace.

Issue Details

Issue Number 53

Issue Type Bug

Project VaultWiki 3.x Series

Category Editing / Posting Articles

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 2.0.0 RC1

Fixed Version 2.0.0 RC1 PL1

Milestone (none)

Software DependencyAny

Users able to reproduce bug 1

Users unable to reproduce bug 0

Attachments 0

Assigned Users pegasus

Tags (none)

June 26, 2008 3:41 PM
vimto

Regular Member
Discussion on Wiki Article

I just loaded up the first page that was created in my wiki forum, I tested it by editing and saving the page, this worked fine. I then attempted to add some discussion. Upon clicking on discussion in the tab the page loads fine and tells me that No one has commented on this article. I then click on Post Reply and the page loads with the following error:

Code:

Warning: urlencode() expects parameter 1 to be string, array given in [path]/vault/special_class_wiki.php on line 332 Warning: urlencode() expects parameter 1 to be string, array given in [path]/vault/special_class_wiki.php on line 332

I then entered some text and clicked on save and received the following error:

Code:

Fatal error: Cannot redeclare special_newreply_post_complete() (previously declared in /home/mywebsite/public_html/forums/vault/special_plugins_general.php:167) in /home/mywebsite/public_html/forums/vault/special_plugins_newreply.php on line 29

The text is saved but then the discussion link on main article fails to load, if you click on the comments link it will show the coment that I added but with a broken template, many things not lined up correctly etc. (tested on vbulletin default full width style)

One other thing I have noticed after editing an article is that it enters the < p > tags around any text that you have entered.
Reply
June 26, 2008 3:55 PM

vimto

Regular Member

Bug in admin panel...maybe

After I had run the upgrade I noticed that there was an upgrade alert for vbulletin version 3.7.2 and a template that needed reverting.

I first clicked on the template and noticed that it was the vault header template which I reverted to the newer version.

Upon returning to my control panel home the vbulletin upgrade alert was gone, even though I never performed the upgrade, so it should still be there.....

Reply
June 26, 2008 4:02 PM

pegasus

VaultWiki Team

This is not functionality that was added by VaultWiki, so I suspect that it is a bug in vBulletin if at all.

Reply
June 26, 2008 4:06 PM

pegasus

VaultWiki Team

Oh, sorry I only responded to your last post. Reopening this issue.

Reply
June 26, 2008 4:18 PM

pegasus

VaultWiki Team

Were you creating a Header for a Wiki forum or a non-Wiki forum? Also, did you change the title while you were editing it?

For the function redeclare, it's safe to remove the special_newreply_post_complete function entirely from the special_plugins_general.php file.

As for the urlencode() bug, I believe this has already been fixed for RC2, but I'm having trouble finding what we changed to fix this.

When your discussion tab was failing to load via AJAX, this was caused by a parse error from one of your other plugins. This should have been fixed by enabling legacy hooks in VaultWiki's options.

Reply
June 26, 2008 4:26 PM

vimto

Regular Member

Originally Posted by pegasus

Were you creating a Header for a Wiki forum or a non-Wiki forum? Also, did you change the title while you were editing it?

It was for a non Wiki Forum, the edit header option doesn't appear on the wiki forums.

Originally Posted by pegasus

For the function redeclare, it's safe to remove the special_newreply_post_complete function entirely from the special_plugins_general.php file.

As for the urlencode() bug, I believe this has already been fixed for RC2, but I'm having trouble finding what we changed to fix this.

Good luck, feel free to test on my website if you wish.

I had a few problems doing the upgrade on my site which was mainly down to the editing the config.php and removing the functions_vault.php code, I'd uploaded the files as instructed, edited the config.php file, then tried to enter the admin panel but it wouldn't allow me, something about a cookie already being sent. I then reverted the config.php file and it allowed me to enter the admin panel and run the upgrade script but then came up with the same error which went away when i made the required changes to the config file again....worked in the end though, but could create support problems for you.

Reply
June 26, 2008 4:33 PM

pegasus

VaultWiki Team

Ah thanks for this. I should add to the instructions that when upgrading from Beta 3 you should first disable the product via the Product Manager. Since RC1, this should no longer be necessary.

Reply
June 26, 2008 7:56 PM

pegasus

VaultWiki Team

For the "call to member function save()" error, try this.

In vault/tabs/special_tab_edit.php, find:

PHP Code:

else if ($threadinfo['threadid'] == 'error') { // ### NOT PREVIEW - ACTUAL POST ###

Replace with:

PHP Code:

else if ($vault->misc['creating_article']) { // ### NOT PREVIEW - ACTUAL POST ###

Reply
June 27, 2008 10:54 AM

vimto

Regular Member

The error is gone, but I'm now getting Page not Found instead.

also, when I first create a header I'm getting the page not found error, this is actually saving the data to my wiki forum (not the header forum). If I then go back to the forum the changed text is not showing, but if I then edit it again it is showing the edited text that I originally created.

Summary:
First edit saves data but gives error "page not found"
Second edit displays saved information with no errors
Header in forum isn't being updated with new information
Header information is being saved in the wrong forum

Entering anything into the Title text box results in "page not found"

Reply
June 27, 2008 12:05 PM

pegasus

VaultWiki Team

This last one is a very stange error. I cannot reproduce it at all on my installation, which leads me to believe it is some sort of conflict. I'm trying to work it out now.

Reply
June 27, 2008 6:08 PM

pegasus

VaultWiki Team

Okay, this issue arises when you use the default variable "title" for your URLs. This conflicts with the subject form variable when creating and editing articles, resulting in namespace abiguity. The subject field should instead use a different variable "edittitle".

vimto, please update your vault_edit_main template to reflect this change until I upload a patch tonight. Anyone else should wait until the patch is uploaded, since only vimto has already made some file edits not mentioned here.

Reply
June 28, 2008 3:06 AM

vimto

Regular Member

Template updated and working fine, allows me to create a header and save it. It is saving to the correct forum and being displayed the forum it was created in.

There is a problem with re-editing it from that forum though when you click on the "(edit this header)" link as it just takes me to my forum index page.

Reply
June 28, 2008 8:51 AM

pegasus

VaultWiki Team

The malformed header edit link was fixed in PL1.

Reply
June 29, 2008 7:57 AM

vimto

Regular Member

Can you let me know which file to upload so I can get it working?

Reply
June 29, 2008 11:09 AM
pegasus

VaultWiki Team
The following files were changed in PL1:

showwiki.php
admincp/vaultwiki.php
clientscript/special_cphome.js
vault/special_class_postbit.php
vault/special_class_wiki.php
vault/special_plugins_admin.php
vault/special_plugins_general.php
vault/tabs/special_tab_edit.php

And you need to reinstall the product.
Reply

+ Reply

All times are GMT -4. The time now is 6:22 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: 2.0 Bugs found

Issue Tools