Issue: Vaultwiki causes template modification in account_wrapper template to not function properly

Since the other template modification was added by you, this is not a bug in VaultWiki.

You should modify the order that the template modifications are applied (probably make your modification occur after VaultWiki's modification). If that does not work on its own, then you may need to alter your modification in some way to avoid the conflict.

That's not right, though. There is something screwy with the way Vaultwiki is modifying the output.

1. The template modification was added by an addon, not by me personally.

2. We have 4 addons that modify that area of the page. They all work fine together. It's only when Vaultwiki is enabled that the likes link breaks. Something is screwy with the way Vaultwiki is inserting that link.

3. As far as I can tell, Vaultwiki isn't using a template modification to inject those links, so there is no way for me to move this template modification to after Vaultwiki's. As a test, I changed the execution order to 10000 and the problem still exists.

4. I understand the hesitance to look into what appears to not be a vaultwiki issue, but the fact remains that we have several addons that work fine in tandem in this area. ONLY when vaultwiki is enabled do we experience this issue.

I'm not trying to be aggressive here, but it's obvious that Vaultwiki has some sort of issue with the way it's inserting the 3 links into the account_wrapper template. I would appreciate it if you'd actually take a glance at the code and correct the issue affecting us.

Thanks for the clarification. I've looked at it, and while VaultWiki is not really doing anything non-standard here (it's using XenForo's template hook, rather than a modification as I thought), the code expects that the likes link will always be there (as there was no way to disable it in default XenForo). This results in a conflict with the other add-on "Remove Likes", because template modifications occur before template hooks.

I've fixed this on your site, but I'd like to try to implement a more elegant solution so that the links are still in the intended position and so that the execution order technique would work.

A true fix, which uses a hybrid template modification + template hook combination, will be included in the next release.

It seems like the best solution would be to use a negative lookahead or some other detection method to find the last occurrence of </li> inside the account_wrapper_sidebar_your_account hook and append your links after that last list item. That way the number or names of the links in the sidebar doesn't matter.

Posted at the same time. Glad to hear there will be a proper fix for this in future releases.

Thanks

It's easier to get the last item than that. The problem was positioning the content-related links near other content-related links when any of those other links might have been removed (there was a bug report a few months ago requesting that we do this).

We've added our own "slot" using a template modification with execution order = 1, so the slot should be added before most other modifications have a chance to remove anything. Then in our hook, we look for the presence of our slot to add our links template there. This should cover basically any combination. It would now be possible to use template modifications to move/remove our slot if desired as well.

Smart! I'll remember that trick for my future addons.