• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 4.x Series
    • Bug
    • Chronological order of wikis completely disrupted by import

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: Chronological order of wikis completely disrupted by import

    • Issue Tools
      • View Changes
    1. issueid=4486 December 23, 2015 8:31 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Chronological order of wikis completely disrupted by import

      After the import from VW3 to VW4 all wiki articles have lost their chronological order. i.e. many hundreds of old articles appear as if these are newly edited.
      For example with reasons like this:
      Reason: converted link format during import

      In many cases the author of the 'automatic edit' has not been around for years or is even diseased.
      Its not a good idea to have these placeholder edits appear like this.
      Its important to display the most recently edited articles first.

      It will take years to get the articles back in chronological order.
    Issue Details
    Issue Number 4486
    Issue Type Bug
    Project VaultWiki 4.x Series
    Category Importing
    Status Fixed
    Priority 3 - Loss of Functionality
    Affected Version 4.0.7
    Fixed Version 4.0.9
    Milestone (none)
    Software DependencyvBulletin 3.x
    License TypePaid
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. December 24, 2015 7:23 AM
      pegasus pegasus is offline
      VaultWiki Team
      It is important to provide the automatic edit instead of replacing the old edits, in case you need to reverse the automatic edit. I have updated the importer so that automatic edit will take place 1 second after the expected recent edit. This should not throw off the validity of Special:RecentChanges as much as before.
      Reply Reply
    2. January 3, 2016 9:34 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      This does not seem to be fixed in 4.0.8b3
      Reply Reply
    3. January 3, 2016 10:13 PM
      pegasus pegasus is offline
      VaultWiki Team
      You are right. This change missed the cutoff for 4.0.8 by a few hours. The corresponding changeset is actually scheduled for the following release.
      Reply Reply
    4. January 3, 2016 10:23 PM
      pegasus pegasus is offline
      VaultWiki Team
      You can apply the change manually if you will be running your live import. In vault/core/controller/import/handle/vw3/link/vw.php, find:
      Code:
      		$pagedm->set('pagetext', $page['pagetext']);
      		$pagedm->set('reason', 'converted link format during import');
      After it, add:
      Code:
      		if (!empty($page['edit_dateline']))
      		{
      			$pagedm->set_info('custom_dateline', 1);
      			$pagedm->set('edit_dateline', $page['edit_dateline'] + 1);
      		}
      This will make the fake edit take place 1 second after the last real edit, which will have a negligible effect on chronology.
      Reply Reply
    5. January 4, 2016 5:38 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Are there other issues related to my site that are not in the current build?
      Reply Reply
    6. January 4, 2016 5:51 PM
      pegasus pegasus is offline
      VaultWiki Team
      I see some other vBulletin 3-only fixes still on the development branch, but they are not related to import. They are related to search functions. If you encounter those, I can post the patches for you.
      Reply Reply
    7. January 4, 2016 6:07 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Thanks.
      Reply Reply
    8. January 4, 2016 6:22 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Weird. After applying the patch it doesn't fix the issue. Yet, I have seen that you did fix the issue before I overwrote all files with the current build.
      Reply Reply
    9. January 5, 2016 10:37 AM
      pegasus pegasus is offline
      VaultWiki Team
      I will have to check again. It's possible setting a custom date is only working correctly for historical versions and not "new" edits. Did you run a fresh import, or try to re-import over the previous one?
      Reply Reply
    10. January 5, 2016 7:00 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      I reimported over the previous one. I will do a fresh import once I do not encounter issues with reimport, because fresh copy of the site takes effort to setup due to the complexity of the big board.
      it indeed relates to 'new' edits. For example creating a category page.
      Reply Reply
    11. January 6, 2016 8:50 AM
      pegasus pegasus is offline
      VaultWiki Team
      Re-importing over the previous import will use the last date (which was incorrect) for the fake edit, since the fake edit must be the current edit, and the current edit must be the most recent. This would explain why you thought the issue was not fixed. I checked some of the articles where a 'converted link format' edit appeared, and indeed it appears in the history 1 second after whenever the previous edit was. So this appears to be working correctly with the change I gave you above.

      To be clear, you do not have to create a new copy of the site every time you want to re-import. You can achieve a fresh VaultWiki by uninstalling+reinstalling VaultWiki, or you can actually do this by modifying the file vault/core/controller/cp/impex/vw.php, and adding the following to the top of the execute() block:
      Code:
      $this->clear();
      The next time you visit the importer, it should delete all non-default content from the wiki. Absolutely, remove the code after you confirm the wiki is now empty. You don't want to accidentally delete the whole wiki later when you want to keep it.
      Reply Reply
    12. January 6, 2016 9:08 AM
      pegasus pegasus is offline
      VaultWiki Team
      Regarding categories, it took me a while to understand why you mentioned it, but it appears that categories that did not exist as pages already but that were referenced by the "category" BB-Code were being created at the current time rather than at the time of the "conversion" edit. You can fix this like so.

      In vault/core/controller/dm/page/vw.php, add the following method to the class:
      Code:
      	public function get_current_dateline()
      	{
      		if ($this->instance->get_info('custom_dateline'))
      		{
      			if ($this->instance->get_existing('pageid'))
      			{
      				return $this->instance->get_info('edit_dateline');
      			}
      		}
      		else if ($this->instance->get_existing('pageid'))
      		{
      			return vw_Hard_Core::controller('Request')->timenow();
      		}
      
      		return $this->instance->get('dateline');
      	}
      Find:
      Code:
      $this->categorydms["$key"]->add_type('Category');
      After it, add:
      Code:
      $this->categorydms["$key"]->set('dateline', $this->get_current_dateline());
      Reply Reply
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 12:57 AM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2023 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2023 DragonByte Technologies Ltd.
    Copyright © 2008 - 2013 VaultWiki Team, Cracked Egg Studios, LLC.