It seems that there is
a bug in XenForo. If a form is not marked with the "AutoValidator" class, then if the last editor action was to insert an image via the editor button, it doesn't actually update the "real" editor contents. You must actually type something else after that to get the editor to consider itself "updated".
On the other hand if the form is marked with "AutoValidator", the act of validating (which would occur when you click the submit button, but before it submits) triggers an editor-contents update anyway, which is why it seems to work normally in most other XenForo content. VaultWiki does not support the auto-validation feature at this time.
I have confirmed this behavior by looking at the POST data that is actually sent to VaultWiki with and without the "AutoValidator" class applied to the form. Without the "AutoValidator" class, the form sends it as if there was no change to the editor content. VaultWiki doesn't really have control over what the editor claims it has (the editor is made by Redactor, with some functionality added by XenForo). On the other hand, including the "AutoValidator" class, the form sends the expected content of the editor, but VaultWiki doesn't support auto-validation, so it returns an "unspecified error" instead of saving.
Unless XenForo devs get to this first, the only way to "fix" this in VaultWiki is to make all our forms support the AutoValidator. This is a relatively big change and wouldn't be ready until a new release. In the mean time, images added via the editor button (rather than entered manually), will work in these cases:
- Insert Image.
- Pick one:
- Type/un-type some text.
- Click "Use BB-Code Editor".
- Submit.
- The image should be saved.