Issue: URL Might Double Domain If Filename Empty

Issue Tools
- View Changes

January 17, 2015 12:30 AM

pegasus

VaultWiki Team

URL Might Double Domain If Filename Empty

So with the following configuration, we might have a doubled domain bit in the URLs for non-top-level areas and regular pages:

URL Format: /wiki-filename/Article
Wiki Filename: (empty)

Fixed in the next release. This is a rare configuration, so the upgrade script will not rebuild URLs automatically.

In vault/core/model/url/vw.php, find:

Code:

							$parent_path = $parent['url'];
							$basebits = explode('/', $parent_path);
							array_pop($basebits);
							$parent_bit = array_pop($basebits);

							if ($parent_bit)

Replace with:

Code:

							$parent_path = $parent['url'];
							$prot_pos = strpos($parent_path, '://');

							if ($prot_pos)
							{
								$parent_path = substr($parent_path, $prot_pos + 3);
							}

							$basebits = explode('/', $parent_path);
							array_shift($basebits);
							array_pop($basebits);
							$parent_bit = '';

							if ($basebits)
							{
								$parent_bit = array_pop($basebits);
							}

							if ($parent_bit)

After upgrading or applying this patch, affected installations should rebuilds URLs manually in Admin Panel > Maintenance > Counters > Rebuild URLs.

Issue Details

Issue Number 4147

Issue Type Bug

Project VaultWiki 4.x Series

Category URLs / Routing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.0

Fixed Version 4.0.1

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

+ Reply

All times are GMT -4. The time now is 12:32 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: URL Might Double Domain If Filename Empty

Issue Tools