Issue: ACP is not responsive

Issue Tools
- View Changes

November 3, 2014 7:28 AM

Alfa1

Distinguished Member

ACP is not responsive

Its pretty difficult to adjust ACP settings on mobile. All radio buttons are aligned in a vertical row, instead of side by side. The text is separated from the buttons so its not clear what each button means.

Please port all VW ACP pages over to XF ACP.

EDIT: this problem also occurs in desktop, so its nto a mobile issue but a general issue.

Issue Details

Issue Number 4055

Issue Type Bug

Project VaultWiki 4.x Series

Category Styling / CSS

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.0 RC 4

Fixed Version 4.0.0 RC 5

Milestone VaultWiki 4.0 Gold

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

November 3, 2014 9:35 AM

pegasus

VaultWiki Team

Please let me know what device you are using. We did some testing on Android a few versions back and I thought we had made the ACP responsive at that time. However, it may not have helped for some other devices so if that's the case, then we need to look at those devices.

Reply
November 3, 2014 9:44 AM

Alfa1

Distinguished Member

Its the same on desktop: http://awesomescreenshot.com/04c3ryfka3

Reply
November 3, 2014 9:53 AM

pegasus

VaultWiki Team

Are there any 404 errors in the Network tab when you visit on desktop, or any errors in the console? It seems like either one of the CSS files was not uploaded or cannot be opened by the browser for another reason.

Reply

November 3, 2014 10:22 AM

Alfa1

Distinguished Member

This is missing:

Code:

https://xenreviews.com/yui-combo/3.17.2/oop/oop-min.js,event-custom-base/event-custom-base-min.js,event-base/event-base-min.js,dom-core/dom-core-min.js,dom-base/dom-base-min.js,selector-native/selector-native-min.js,selector/selector-min.js,node-core/node-core-min.js,dom-style/dom-style-min.js,node-base/node-base-min.js,node-style/node-style-min.js,event-delegate/event-delegate-min.js,event-custom-complex/event-custom-complex-min.js,event-synthetic/event-synthetic-min.js,event-mousewheel/event-mousewheel-min.js,event-mouseenter/event-mouseenter-min.js,event-key/event-key-min.js,event-focus/event-focus-min.js,event-resize/event-resize-min.js,event-hover/event-hover-min.js,event-outside/event-outside-min.js,event-touch/event-touch-min.js,event-move/event-move-min.js,event-flick/event-flick-min.js,event-valuechange/event-valuechange-min.js,event-tap/event-tap-min.js

November 3, 2014 10:43 AM

pegasus

VaultWiki Team

I see the issue is that nginx is looking only for a file named that, and does not pass the URL to XenForo for processing if it doesn't exist. I'll see if I can write a workaround for this behavior this morning.

It still doesn't explain why the style is broken, though.

Reply

November 3, 2014 11:39 AM

pegasus

VaultWiki Team

In library/vw/XenForo/Route/Prefix/YuiCombo.php, find:

Code:

		$version = strpos($routePath, '/');

		if ($version !== false)
		{
			$_REQUEST['f'] = substr($routePath, $version + 1);
		}

Replace with:

Code:

		if (empty($_REQUEST['f']))
		{
			$version = strpos($routePath, '/');

			if ($version !== false)
			{
				$_REQUEST['f'] = substr($routePath, $version + 1);
			}
		}

In vault/core/view/global/vw.php, find:

Code:

$path = 'yui-combo/' . vw_Hard_Core::YUI_VERSION . '/';

Replace with:

Code:

$path = 'yui-combo/' . vw_Hard_Core::YUI_VERSION . '/?f=';

For the next release, I have made this change only apply to XenForo. Since vBulletin installs have to manually configure the yui-combo path anyway, nginx would not be able to get confused in vBulletin.

November 3, 2014 4:50 PM

Alfa1

Distinguished Member

This is fixed

Reply

+ Reply

All times are GMT -4. The time now is 9:46 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: ACP is not responsive

Issue Tools