Issue: Installing Phrases

Issue Tools
- View Changes

October 5, 2014 12:45 AM

rizwank

New Member

Installing Phrases

I kept having to reclick next on installing phrases. I think I double clicked once and got

Code:

installing_phrases
Importing phrase group: xf
An exception occurred: Mysqli statement execute error : Duplicate entry 'vw_tab_history-0' for key 'title' in /var/www/html/forum/library/Zend/Db/Statement/Mysqli.php on line 214
Zend_Db_Statement_Mysqli->_execute() in library/Zend/Db/Statement.php at line 297
Zend_Db_Statement->execute() in library/Zend/Db/Adapter/Abstract.php at line 479
Zend_Db_Adapter_Abstract->query() in library/Zend/Db/Adapter/Abstract.php at line 574
Zend_Db_Adapter_Abstract->insert() in library/XenForo/DataWriter.php at line 1624
XenForo_DataWriter->_insert() in library/XenForo/DataWriter.php at line 1613
XenForo_DataWriter->_save() in library/XenForo/DataWriter.php at line 1405
XenForo_DataWriter->save() in vault/core/controller/install/common/xf.php at line 131
vw_Install_Common_Controller_XF->do_language() in vault/core/controller/install/upgradepath/steps/final/xf.php at line 61
vw_Install_UpgradePath_Steps_Final_Controller_XF->{closure}() in vault/core/controller/install/upgradepath/vw.php at line 63
vw_Install_UpgradePath_Controller->call() in vault/core/controller/cp/install/vw.php at line 299
vw_CP_Install_Controller->exec_step() in vault/core/controller/cp/install/vw.php at line 230
vw_CP_Install_Controller->upgrade() in vault/core/controller/cp/install/vw.php at line 71
vw_CP_Install_Controller->execute() in library/vw/XenForo/ControllerAdmin/Wiki.php at line 113
vw_XenForo_ControllerAdmin_Wiki->actionIndex() in library/vw/XenForo/ControllerAdmin/Wiki.php at line 142
vw_XenForo_ControllerAdmin_Wiki->actionUpgrade() in library/XenForo/FrontController.php at line 347
XenForo_FrontController->dispatch() in library/XenForo/FrontController.php at line 134
XenForo_FrontController->run() in admin.php at line 13

Fixed it with

Code:

delete from xf_phrase where title like 'vw_tab_h%' OR title like 'vw_tab_l%' OR title like 'vw_tab_m%' OR title like 'vw_tab_o%' OR title like 'vw_tab_p%' OR title like 'vw_tab_r%' OR title like 'vw_tab_s%' OR title like 'vw_tab_t%' OR title like 'vw_tab_u%' OR title like 'vw_tab_v%' OR title like 'vw_tab_w%' OR  title like 'vw_talk%' OR title like 'vw_template_%' OR title like 'vw_template%' OR title like 'vw_thread%'  OR title like 'vw_title%'  OR title like 'vw_to%'  OR title like 'vw_tr%'   OR title like 'vw_u%'   OR title like 'vw_ty%'   OR title like 'vw_v%'  OR title like 'vw_w%' OR  title like 'vw_x%'  OR title like 'vw_y%'  OR title like 'vw_z%'  OR title like 'vw_z%'  
OR title like 'vwc%'  OR title like 'vwp%'

but that was a pain in the ass to sort out.

Issue Details

Issue Number 4025

Issue Type Bug

Project VaultWiki 4.x Series

Category Install / Upgrade

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.0.0 RC 3

Fixed Version 4.0.0 RC 4

Milestone VaultWiki 4.0 Gold

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 5, 2014 1:24 AM

pegasus

VaultWiki Team

When you "step into" the upgrade process, it is by design that you have to keep clicking next. This is Manual Mode, and we avoid Javascript at all costs so that Javascript is removed as a point of failure.

Unfortunately, if you double-clicked the button, you submitted two requests to the next batch and you ran the same batch twice. Since they started at roughly the same time, you entered a race condition. The created data was not available as "existing data" when either request started, so they continued as if everything needed to be created. Thus, one request created the data, and the other request got a duplicate error. Usually the browser will show the output of the second request. If you are lucky, maybe the first request will be slower and get the duplicate error instead (and you won't see it).

The only real way around this is to use Javascript to disable the buttons after they are clicked the first time. This goes against some of the ideals of Manual Mode, but it is probably necessary to avoid race conditions like this.

Reply
October 5, 2014 11:19 AM

pegasus

VaultWiki Team

Fixed in the next release by making the Next button disable itself when clicked.

Reply

+ Reply

All times are GMT -4. The time now is 3:29 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Installing Phrases

Issue Tools