Issue: Items now showing up in Moderation panel

Issue Tools
- View Changes

August 24, 2014 4:21 PM

delicateglow

Junior Member

Items now showing up in Moderation panel

If there are comments that need to be moderated first, it will not show up in the moderation panel in the VW admin panel.
This also applies to any edits made in to articles. It'll display "This page has an edit awaiting moderation." but nothing is shown in the mod panel.
Additionally, it seems that the following setting:
"Are new wiki pages NOT moderated?"
Set to no or never, it ignores it. It will still make the page and not be set under moderation

EDIT: If you handle the edits through Edit History, even after handling them all, it will still display "This page has an edit awaiting moderation."

Issue Details

Issue Number 3954

Issue Type Bug

Project VaultWiki 4.x Series

Category Moderator Tools

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.0.0 RC 2

Fixed Version 4.0.0 RC 3

Milestone VaultWiki 4.0 Gold

Software DependencyvBulletin 4.x w/ ckEditor

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 25, 2014 12:27 AM

pegasus

VaultWiki Team

By any chance, were the moderated edits considered as "minor" edits? I just noticed a bug where edits with the minor flag won't remove the pending flag from the page after they are approved. So far that is the only part of this issue I can confirm, but I'm investigating the rest.

Reply
August 25, 2014 5:50 AM

delicateglow

Junior Member

Originally Posted by pegasus

By any chance, were the moderated edits considered as "minor" edits?

No, they were not marked as minor edits.

Reply

August 29, 2014 9:28 AM

pegasus

VaultWiki Team

Fixed new pages not being moderated. In vault/core/controller/ui/edit/vw.php, find:

Code:

if (empty($orig['itemid']) AND !$this->test_permission($edit, 'followmodperms'))

Replace with:

Code:

if (empty($orig['itemid']) AND !$this->test_permission($edit, 'followmodrules'))

Find:

Code:

if (!empty($edit['itemid']) AND ($perms & $bitvalue) != $t_or_f)

Replace with:

Code:

if (($perms & $bitvalue) != $t_or_f)

August 29, 2014 9:41 AM

pegasus

VaultWiki Team

Confirmed that edits, at least, are not actually adding themselves to the moderation queue, even if they are awaiting moderation.

Reply
August 29, 2014 10:55 AM

pegasus

VaultWiki Team

Fixed edits and file updates not appearing in the queue. It had to do with those kinds of changes being considered 'automated'.

Reply
August 29, 2014 11:05 AM

pegasus

VaultWiki Team

Comments are adding to the queue fine for me. Now to handle the issue where minor edits leave the page in limbo after approval.

Reply
August 29, 2014 11:31 AM

pegasus

VaultWiki Team

Upgrade step to handle limbo pages has been written. Marked as fixed in the next release.

Reply

+ Reply

All times are GMT -4. The time now is 7:58 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Items now showing up in Moderation panel

Issue Tools