Issue: Nested Book TOC, Displayed Nesting Wrong

Issue Tools
- View Changes

April 21, 2014 2:14 PM

Ptah

Junior Member

Nested Book TOC, Displayed Nesting Wrong

The chapters of a nested book show under the wrong parenting book page

Scenario.

Book A contains Book B.
(Not sure if it is relevant, but after populating both with some Chapters, I had moved a Chapter, say C, which was in B, up into A, as in: bringing C up to the same level as B under A)
Look at the TOC of A.
See that the (remaining) sub-chapters of Book B show as if they were under C? Even though C is not a Book, it is just a Page?

Put another way: C is just Page, B is a Book and has subchapters, they are both direct children of A, and yet the TOC of A shows the subchapters of B as if they were subchapters of C, while B looks like it has no subchapters?

This is just a TOC display thing, from the perspective of A, from what I can tell. It seems that when looking at B's own local TOC (from its page), it still knows about its proper subchapters, and likewise, when looking directly at C (from its page), it knows it is flat Page, not a Book, no subchapters. Likewise, the TOC navigation section under page content seems to reflect the proper structure, as well?

Issue Details

Issue Number 3707

Issue Type Bug

Project VaultWiki 4.x Series

Category Books / Chapters

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.0.0 Gamma 5

Fixed Version (none)

Milestone VaultWiki 4 Gamma X

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 21, 2014 4:54 PM

pegasus

VaultWiki Team

Did you notice this after the other Fatal Error you reported? After fixing the Fatal Error, try unparenting C completely from any book, then add it to A again.

Reply
April 21, 2014 5:25 PM

Ptah

Junior Member

Yes, it was after the other fatal error I reported.

I fixed that (thanks), completely unparented C, and the added it back to A.

Same problem/behavior as above.

?

Reply
April 21, 2014 5:27 PM

Ptah

Junior Member

You can see the example I'm referring to here

A="Meta:INTPcomplex"
B="Meta:Forum How-To"
C="Meta:Reputation"

Reply
April 21, 2014 6:04 PM

pegasus

VaultWiki Team

Confirmed here in Demo Book. It looks like the TOC is always appending the next-level chapters to whatever item happens to be at the end of the list.

Reply
April 21, 2014 6:41 PM

pegasus

VaultWiki Team

There's quite a bit wrong with this:
- When inserting a new chapter, it inserts it in the cache between the prior chapter and that chapter's sub-chapters (hence the issue you see)
- When moving an existing chapter to an earlier location, the location is not updated.
- When adding a new chapter that has sub-chapters, the sub-chapters are still in the list for the old parent book (hence the issue you see) and they do not appear in the new parent book.
- When adding a new chapter that will be the only chapter in a sub-book, it gets placed in the list as the first chapter of the highest-level book in that hierarchy.

Reply
April 22, 2014 11:00 AM
pegasus

VaultWiki Team
Fixed in the next build, which will probably be later today. Existing chapter orders will be rebuilt by the upgrade process in the next release. This required relatively massive updates, so I won't be posting the code here.

If you don't want to wait for the next release, once you get the new build, run the following code from within a VaultWiki script:

Code:

vw_Hard_Core::controller('UI/Book')->rebuild_chapter_order(0, 10000);
Reply

+ Reply

All times are GMT -4. The time now is 11:19 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Nested Book TOC, Displayed Nesting Wrong

Issue Tools