Issue: Physically Delete Page = Crash

Issue Tools
- View Changes

April 21, 2014 10:15 AM

Ptah

Junior Member

Physically Delete Page = Crash

Trying to physically delete a page results in errors, crash

Create a page.
Try to physically delete the page.
Get a page with:

Code:

Warning: Illegal offset type in ..../vault/core/controller/dm/base/vw.php on line 534

and

Code:

Database error in vBulletin 4.2.2:

Invalid SQL:
DELETE FROM `vw_subscribe` WHERE  `subscribeid` IN ()  LIMIT 0;

MySQL Error   : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')  LIMIT 0' at line 1
Error Number  : 1064
Request Date  : Monday, April 21st 2014 @ 02:11:54 PM
Error Date    : Monday, April 21st 2014 @ 02:11:55 PM
Script        : [url]http://forums.intpcomplex.com/wiki_inlinemod.php?do=kill[/url]
Referrer      : [url]http://forums.intpcomplex.com/wiki_index.php?title=Sandbox:Example&do=delete[/url]
IP Address    : 71.201.229.147
Username      : Ptah
Classname     : vB_Database
MySQL Version : 5.5.36-cll

(Note: "soft" delete doesn't cause this)

Issue Details

Issue Number 3705

Issue Type Bug

Project VaultWiki 4.x Series

Category Editing Pages

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.0.0 Gamma 5

Fixed Version 4.0.0 Gamma 5

Milestone VaultWiki 4 Gamma X

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 21, 2014 11:29 AM

pegasus

VaultWiki Team

In vault/core/controller/dm/subscribe/vw.php, find:

Code:

public function delete_multiple($subscriptions)

Add before:

Code:

	public function delete()
	{
		$existing = $this->instance->get_existing();

		if ($existing)
		{
			$subscriptions = array(
				$existing['subscribeid'] => $existing
			);
		}
		else if ($this->instance->get_condition())
		{
			$subs = vw_DB::get()->query()->select(array(
				'fields' => array('*'),
				'table' => 'vw_subscribe',
				'where' => $this->instance->get_condition()
			));

			$subscriptions = array();

			while ($sub = vw_DB::get()->func()->fetch_array($subs))
			{
				$subscriptions[$sub['subscribeid']] = $sub;
			}
			vw_DB::get()->func()->free_result($subs);
			unset($sub);
		}

		if empty($subscriptions)
		{
			return true;
		}

		return $this->delete_multiple($subscriptions);
	}

April 21, 2014 11:29 AM

Ptah

Junior Member

FWIW: It seems it does actually delete the page, although it is crashing on the part about unsubscribing to it?

edit: you ninja'ed me there, ok, thanks I'll give that a try.

Reply
April 21, 2014 11:34 AM

Ptah

Junior Member

Confirmed: that fixes it, thanks!

Reply

+ Reply

All times are GMT -4. The time now is 1:00 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Physically Delete Page = Crash

Issue Tools